From: Laurent Vivier <laurent@vivier.eu>
To: Lucien Anti-Spam <lucienmp_antispam@yahoo.com>,
"Emilio G. Cota" <cota@braap.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] m68k gdb has stopped single stepping correctly
Date: Thu, 24 Jan 2019 14:38:02 +0100 [thread overview]
Message-ID: <b74582b9-a1b0-a7cc-b478-a26a140ce055@vivier.eu> (raw)
In-Reply-To: <70145779.391347.1548334794441@mail.yahoo.com>
On 24/01/2019 13:59, Lucien Anti-Spam wrote:
>
>
>> On Thursday, January 24, 2019, 3:08:07 AM GMT+9, Emilio G. Cota
> <cota@braap.org> wrote:
>> > On Wed, Jan 23, 2019 at 15:58:27 +0000, Lucien Anti-Spam via
> Qemu-devel wrote:
>> > Hi folks,
>> > I noticed that with 3.x release that the GDB options (-S -s) for
> certain CPU results in very weird stepping.Usually stops afer a few
> steps, whilst the stub continues responding the PC doesnt update,
> however, I have only deeply looked at the m68k.
>> > In the case of the m68K the SR gets the trace bit set (T=10b), and
> the PC doesnt update.The m68k gdbstub, and main gdbstub seem mostly
> unchanged.But it seems the INSN handling has changed greatly for the m68k.
>> > Does anyone have any ideas what happened?
>>
>> Can you please bisect to find at which point things start misbehaving?
>>
>> Thanks,
>> Emilio
>
> Understood, I was hoping my original post might jog someone's memory
> about the issue.
>
> Apparently not, so after some digging I found that it was introduced
> with the refactor to TranslatorOps, specifically two lines got dropped
> that update the PC if single-stepping is being performed ( commit
> 11ab74b01e0a8ea4973eed89c6b90fa6e4fb9fb6 )
>
> Since its not valid to revert, shall I go ahead and submit a patch for
> these two lines?
It seems to me to be a good solution, but CC'ing Richard for that.
Thanks,
Laurent
next prev parent reply other threads:[~2019-01-24 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <251451940.431966.1548259107629.ref@mail.yahoo.com>
2019-01-23 15:58 ` [Qemu-devel] m68k gdb has stopped single stepping correctly Lucien Anti-Spam
2019-01-23 18:08 ` Emilio G. Cota
2019-01-24 12:59 ` Lucien Anti-Spam
2019-01-24 13:38 ` Laurent Vivier [this message]
2019-01-24 13:38 ` Alex Bennée
2019-02-20 15:38 ` Thomas Huth
2019-02-21 7:39 ` Lucien Anti-Spam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b74582b9-a1b0-a7cc-b478-a26a140ce055@vivier.eu \
--to=laurent@vivier.eu \
--cc=cota@braap.org \
--cc=lucienmp_antispam@yahoo.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).