From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79AFAC00528 for ; Tue, 1 Aug 2023 21:23:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQwom-0003xy-03; Tue, 01 Aug 2023 17:22:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQwok-0003xj-Ao for qemu-devel@nongnu.org; Tue, 01 Aug 2023 17:22:10 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQwoi-0002ER-JK for qemu-devel@nongnu.org; Tue, 01 Aug 2023 17:22:10 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-307d58b3efbso5473301f8f.0 for ; Tue, 01 Aug 2023 14:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690924926; x=1691529726; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=667roFLV/YbxfTprICXPvM+41CddL6PU8tSUuzeNg2Q=; b=RKMaTnNssg3CyALLCXSwvSV07UTMUnEMpba75VB40rvOIhUSgGsBaUWg1023taK+fK N/OQumWz65t5/w7QuZGgSiNUM6thY/g+9nXWTzsa7TPjNO0PMPuDGSwSbSgM7t9oLY9f qRl34ywYvTqev2jcz+A28CK9XWulGWEnC5R/wMKHqX+27Y3lJpo/vCn9aldd4XGMaxBb cx3CgEG5PgwRO7F30pjbnr+ePKj+dATMcQHvn1BVU1KJ0HhVNfay4hHdzdhD2G/wFBP3 n/+DtreS03dkCmp/Te5Yxs0o2CapRMt7y1cJnw5xKXawJi0W7SRshIXWvTNq4SGg505U OmEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690924926; x=1691529726; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=667roFLV/YbxfTprICXPvM+41CddL6PU8tSUuzeNg2Q=; b=CkeX2VURGdt4tfx7brKkM8g/cVthQyoJl8Tpe0Au3snvvwZf0g0lm1qA0oRVAwmMGE KFtUbPvgYZFg1ncKqfn6ZN7SN6rJKirM1P/NOtEHZCMDgN+HWccdvyD5JNUlHJxSHMdo nigNNTlALdwYybIxE/VrmgHvN1Pfb1++KwH93712jbAJTvhQ1OCK9tCz6u6+wacQ+rfY oiXzapAafO6RFf+FvEtkpKYkArGm9upuovmn/9DuIp1R9Rsqi3aaV3/AKNVKHkoitvvC XQXok1768lc/lJut64LkfuxGpOBQ83Pd0xkp03q8eZlCjikGE6tDCr8uADcYvql596AF O8SA== X-Gm-Message-State: ABy/qLYFBpTZLo2ZJp4LfecjRC8lAuOGY/31Vfn4YGSBVp2CxtKzPdDP L4ym5DHWxq7LcnIE7RMf+TpmoA8uCO4/sRKlPh0= X-Google-Smtp-Source: APBJJlEhINZO8GpnmTF77ltBe/fGjnky7aCRBZ+b9tAzs3ZHfgvTmOjJwmHachxfYrklpfgYI2FUdw== X-Received: by 2002:adf:f9c3:0:b0:317:66c0:9d82 with SMTP id w3-20020adff9c3000000b0031766c09d82mr3085936wrr.64.1690924926647; Tue, 01 Aug 2023 14:22:06 -0700 (PDT) Received: from [192.168.69.115] ([176.176.174.59]) by smtp.gmail.com with ESMTPSA id k17-20020adfe8d1000000b003143867d2ebsm17072173wrn.63.2023.08.01.14.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 14:22:06 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 23:22:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/3] accel/tcg: Do not issue misaligned i/o Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org References: <20230801184220.75224-1-richard.henderson@linaro.org> <20230801184220.75224-4-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230801184220.75224-4-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.092, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/8/23 20:42, Richard Henderson wrote: > In the single-page case we were issuing misaligned i/o to > the memory subsystem, which does not handle it properly. > Split such accesses via do_{ld,st}_mmio_*. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1800 > Signed-off-by: Richard Henderson > --- > accel/tcg/cputlb.c | 118 +++++++++++++++++++++++++++------------------ > 1 file changed, 72 insertions(+), 46 deletions(-) Reviewed-by: Philippe Mathieu-Daudé