From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Hao QingFeng <haoqf@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: Skip test 162 if there is no SSH support
Date: Wed, 12 Oct 2016 17:36:02 -0500 [thread overview]
Message-ID: <b77727d4-1a1d-ab67-5146-eaef5a3907c9@redhat.com> (raw)
In-Reply-To: <20161012204907.25941-4-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
On 10/12/2016 03:49 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/162 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162
> index f8eecb3..cad2bd7 100755
> --- a/tests/qemu-iotests/162
> +++ b/tests/qemu-iotests/162
> @@ -35,6 +35,9 @@ status=1 # failure is the default!
> _supported_fmt generic
> _supported_os Linux
>
> +test_ssh=$($QEMU_IMG --help | grep '^Supported formats:.* ssh\( \|$\)')
> +[ "$test_ssh" = "" ] && _notrun "ssh support required"
> +
Reviewed-by: Eric Blake <eblake@redhat.com>
> echo
> echo '=== NBD ==='
> # NBD expects all of its arguments to be strings
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-10-12 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 20:49 [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support Max Reitz
2016-10-12 20:49 ` [Qemu-devel] [PATCH 1/3] block: Fix bdrv_iterate_format() sorting Max Reitz
2016-10-12 21:31 ` Eric Blake
2016-10-12 20:49 ` [Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format() Max Reitz
2016-10-12 22:35 ` Eric Blake
2016-11-02 10:52 ` Hao QingFeng
2016-11-02 11:15 ` Kevin Wolf
2016-11-02 11:59 ` Hao QingFeng
2016-11-02 15:29 ` Eric Blake
2016-10-12 20:49 ` [Qemu-devel] [PATCH 3/3] iotests: Skip test 162 if there is no SSH support Max Reitz
2016-10-12 22:36 ` Eric Blake [this message]
2016-10-12 22:26 ` [Qemu-devel] [PATCH 0/3] iotests: Skip " no-reply
2016-10-28 15:13 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b77727d4-1a1d-ab67-5146-eaef5a3907c9@redhat.com \
--to=eblake@redhat.com \
--cc=haoqf@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).