From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 859A5C7EE31 for ; Fri, 27 Jun 2025 09:40:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uV5Z5-0005s1-VO; Fri, 27 Jun 2025 05:40:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uV5Z2-0005pc-SF for qemu-devel@nongnu.org; Fri, 27 Jun 2025 05:40:09 -0400 Received: from mx2.zhaoxin.com ([61.152.208.219]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uV5Yz-0001QF-DZ for qemu-devel@nongnu.org; Fri, 27 Jun 2025 05:40:08 -0400 X-ASG-Debug-ID: 1751017202-1eb14e1c381fa10001-jgbH7p Received: from ZXSHMBX1.zhaoxin.com (ZXSHMBX1.zhaoxin.com [10.28.252.163]) by mx2.zhaoxin.com with ESMTP id 0wJUcUGjlshiv9r1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 27 Jun 2025 17:40:02 +0800 (CST) X-Barracuda-Envelope-From: EwanHai-oc@zhaoxin.com X-Barracuda-RBL-Trusted-Forwarder: 10.28.252.163 Received: from ZXSHMBX1.zhaoxin.com (10.28.252.163) by ZXSHMBX1.zhaoxin.com (10.28.252.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 27 Jun 2025 17:40:01 +0800 Received: from ZXSHMBX1.zhaoxin.com ([::1]) by ZXSHMBX1.zhaoxin.com ([fe80::2c07:394e:4919:4dc1%7]) with mapi id 15.01.2507.044; Fri, 27 Jun 2025 17:40:01 +0800 X-Barracuda-RBL-Trusted-Forwarder: 10.28.252.163 Received: from [192.168.31.91] (10.28.66.62) by zxbjmbx1.zhaoxin.com (10.29.252.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 27 Jun 2025 13:52:43 +0800 Message-ID: Date: Fri, 27 Jun 2025 13:52:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Ewan Hai Subject: Re: [PATCH 2/4] i386/cpu: Mark CPUID 0x80000007[EBX] as reserved for Intel To: Zhao Liu , Paolo Bonzini , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Igor Mammedov X-ASG-Orig-Subj: Re: [PATCH 2/4] i386/cpu: Mark CPUID 0x80000007[EBX] as reserved for Intel CC: Xiaoyao Li , Tao Su , Yi Lai , Dapeng Mi , References: <20250627035129.2755537-1-zhao1.liu@intel.com> <20250627035129.2755537-3-zhao1.liu@intel.com> In-Reply-To: <20250627035129.2755537-3-zhao1.liu@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.28.66.62] X-ClientProxiedBy: ZXSHCAS1.zhaoxin.com (10.28.252.161) To zxbjmbx1.zhaoxin.com (10.29.252.163) X-Moderation-Data: 6/27/2025 5:40:00 PM X-Barracuda-Connect: ZXSHMBX1.zhaoxin.com[10.28.252.163] X-Barracuda-Start-Time: 1751017202 X-Barracuda-Encrypted: ECDHE-RSA-AES128-GCM-SHA256 X-Barracuda-URL: https://10.28.252.36:4443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at zhaoxin.com X-Barracuda-Scan-Msg-Size: 1484 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Spam-Score: -0.94 X-Barracuda-Spam-Status: No, SCORE=-0.94 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests=DATE_IN_PAST_03_06, DATE_IN_PAST_03_06_2 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.143463 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 1.08 DATE_IN_PAST_03_06_2 DATE_IN_PAST_03_06_2 Received-SPF: pass client-ip=61.152.208.219; envelope-from=EwanHai-oc@zhaoxin.com; helo=mx2.zhaoxin.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/27/25 11:51 AM, Zhao Liu wrote: > > Per SDM, > > 80000007H EAX Reserved = 0. > EBX Reserved = 0. > ECX Reserved = 0. > EDX Bits 07-00: Reserved = 0. > Bit 08: Invariant TSC available if 1. > Bits 31-09: Reserved = 0. > > EAX/EBX/ECX in CPUID 0x80000007 leaf are reserved for Intel. > > At present, EAX is reserved for AMD, too. And AMD hasn't used ECX in > QEMU. So these 2 registers are both left as 0. > > Therefore, only fix the EBX and excode it as 0 for Intel. > > Signed-off-by: Zhao Liu > --- > target/i386/cpu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 867e08236540..6d590a9af389 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -8374,7 +8374,11 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, > } > case 0x80000007: > *eax = 0; > - *ebx = env->features[FEAT_8000_0007_EBX]; > + if (cpu->vendor_cpuid_only_v2 && IS_INTEL_CPU(env)) { Please add IS_ZHAOXIN_CPU(env), because Zhaoxin follows the SDM definition for CPUID leaf 0x80000008. > + *ebx = 0; > + } else { > + *ebx = env->features[FEAT_8000_0007_EBX]; > + } > *ecx = 0; > *edx = env->features[FEAT_8000_0007_EDX]; > break; > -- > 2.34.1 >