From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF0FCC433DB for ; Mon, 1 Mar 2021 15:39:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71E0C64DF5 for ; Mon, 1 Mar 2021 15:39:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71E0C64DF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGkdg-0007QV-If for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 10:39:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGkco-0006U3-LJ for qemu-devel@nongnu.org; Mon, 01 Mar 2021 10:38:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lGkck-0004kb-1c for qemu-devel@nongnu.org; Mon, 01 Mar 2021 10:38:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614613096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lzf7uQzOkBy89QAZ4omcHjYitYA7TbcIh/V5HxbAR98=; b=DUMUWKQMViDFUG9IlTxcNz/w9cfbIW8e6un2Vu7tuJevOhIYFbbOBittKgt6jhNfNo+ofv j4kSFdY7wdX7a0lQMmzyQKMx4+FhuW0ZCyvvpOgVeJBRUo8na1oAkmahQ7//t5PfnhIiws I5WlhUJUJF2pchHdikqmyguu16GErV0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-vyu-ZdcCOgmyX8R730Ek7Q-1; Mon, 01 Mar 2021 10:38:13 -0500 X-MC-Unique: vyu-ZdcCOgmyX8R730Ek7Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 623061966339; Mon, 1 Mar 2021 15:38:12 +0000 (UTC) Received: from [10.3.113.12] (ovpn-113-12.phx2.redhat.com [10.3.113.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FE971002C11; Mon, 1 Mar 2021 15:38:12 +0000 (UTC) Subject: Re: [PATCH v2 1/2] storage-daemon: report unexpected arguments on the fly To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210301152844.291799-1-pbonzini@redhat.com> <20210301152844.291799-2-pbonzini@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Mon, 1 Mar 2021 09:38:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210301152844.291799-2-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/1/21 9:28 AM, Paolo Bonzini wrote: > If the first character of optstring is '-', then each nonoption argv > element is handled as if it were the argument of an option with character > code 1. This removes the reordering of the argv array, and enables usage > of loc_set_cmdline to provide better error messages. > > Signed-off-by: Paolo Bonzini > --- > storage-daemon/qemu-storage-daemon.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) Nice. The man page for 'getopt_long' is unclear whether setting POSIXLY_CORRECT in the environment would break this (that is, setting POSIXLY_CORRECT has the same effect as a leading '+'; but you can't have both leading '+' and leading '-' and when both are set, it is not clear which one wins). But that's a corner case that I don't think will ever bite us in real life. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org