Re: [PATCH 03/10] accel/tcg: Introduce TCGCPUOps.cpu_exec_reset

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 28/4/25 22:10, Richard Henderson wrote:
> Initialize all instances with cpu_reset(), so that there
> is no functional change.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/accel/tcg/cpu-ops.h | 2 ++
>   accel/tcg/cpu-exec.c        | 3 ++-
>   target/alpha/cpu.c          | 1 +
>   target/arm/cpu.c            | 1 +
>   target/arm/tcg/cpu-v7m.c    | 1 +
>   target/avr/cpu.c            | 1 +
>   target/hppa/cpu.c           | 1 +
>   target/i386/tcg/tcg-cpu.c   | 1 +
>   target/loongarch/cpu.c      | 1 +
>   target/m68k/cpu.c           | 1 +
>   target/microblaze/cpu.c     | 1 +
>   target/mips/cpu.c           | 1 +
>   target/openrisc/cpu.c       | 1 +
>   target/ppc/cpu_init.c       | 1 +
>   target/riscv/tcg/tcg-cpu.c  | 1 +
>   target/rx/cpu.c             | 1 +
>   target/s390x/cpu.c          | 1 +
>   target/sh4/cpu.c            | 1 +
>   target/sparc/cpu.c          | 1 +
>   target/tricore/cpu.c        | 1 +
>   target/xtensa/cpu.c         | 1 +
>   21 files changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h
> index 60b5e97205..3ff72b8d9d 100644
> --- a/include/accel/tcg/cpu-ops.h
> +++ b/include/accel/tcg/cpu-ops.h
> @@ -155,6 +155,8 @@ struct TCGCPUOps {
>       void (*do_interrupt)(CPUState *cpu);
>       /** @cpu_exec_interrupt: Callback for processing interrupts in cpu_exec */
>       bool (*cpu_exec_interrupt)(CPUState *cpu, int interrupt_request);
> +    /** @cpu_exec_reset: Callback for reset in cpu_exec.  */
> +    void (*cpu_exec_reset)(CPUState *cpu);

I'm not sure "cpu_exec" is still relevant these days, maybe we can
directly call it "cpu_reset()". Anyhow,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>       /**
>        * @cpu_exec_halt: Callback for handling halt in cpu_exec.
>        *