From: Max Reitz <mreitz@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize
Date: Mon, 9 Sep 2019 12:06:43 +0200 [thread overview]
Message-ID: <b7cf5a8e-9199-8405-8a32-470cd5437b9e@redhat.com> (raw)
In-Reply-To: <20190729213559.20913-2-jsnow@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 762 bytes --]
On 29.07.19 23:35, John Snow wrote:
> Like script_main, but doesn't require a single point of entry.
> Replace all existing initialization sections with this drop-in replacement.
>
> This brings debug support to all existing script-style iotests.
>
> Note: supported_oses=['linux'] was omitted, as it is a default argument.
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
Looks good to me, but I’m afraid I looked at this series too late (that
is, now), so I sent my own version of your 2/3, sorry. :-/
That means that this needs a bit of rebasing and what remains of 2/3
afterwards (I haven’t converted existing tests using verify_protocol, so
that still needs to be done) should probably be squashed into this patch
here.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-09 10:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:35 [Qemu-devel] [PATCH v2 0/3] iotests: use python logging John Snow
2019-07-29 21:35 ` [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize John Snow
2019-09-09 10:06 ` Max Reitz [this message]
2019-09-09 18:25 ` John Snow
2019-09-10 8:41 ` Max Reitz
2019-07-29 21:35 ` [Qemu-devel] [PATCH v2 2/3] iotests: add protocol support to initialization info John Snow
2019-09-09 10:09 ` Max Reitz
2019-09-09 18:45 ` John Snow
2019-09-10 8:43 ` Max Reitz
2019-07-29 21:35 ` [Qemu-devel] [PATCH v2 3/3] iotests: use python logging for iotests.log() John Snow
2019-09-09 10:18 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7cf5a8e-9199-8405-8a32-470cd5437b9e@redhat.com \
--to=mreitz@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).