qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Anton Johansson" <anjo@rev.ng>,
	qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
	qemu-arm@nongnu.org, "Peter Xu" <peterx@redhat.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	qemu-riscv@nongnu.org, "David Hildenbrand" <david@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-s390x@nongnu.org
Subject: Re: [PATCH 06/24] target/rx/cpu: Include missing 'exec/translation-block.h' header
Date: Thu, 14 Nov 2024 10:43:29 -0800	[thread overview]
Message-ID: <b7d12d85-fa22-4b53-ad09-b55ae62e4d9e@linaro.org> (raw)
In-Reply-To: <20241114011310.3615-7-philmd@linaro.org>

On 11/13/24 17:12, Philippe Mathieu-Daudé wrote:
> The TranslationBlock structure is declared in
> "exec/translation-block.h", along with the TB
> compile flag definitions. Include the header
> in order to avoid when refactoring:
> 
>    target/rx/cpu.c:50:42: error: use of undeclared identifier 'CF_PCREL'
>       50 |     tcg_debug_assert(!tcg_cflags_has(cs, CF_PCREL));
>          |                                          ^
>    target/rx/cpu.c:51:21: error: incomplete definition of type 'struct TranslationBlock'
>       51 |     cpu->env.pc = tb->pc;
>          |                   ~~^
>    include/qemu/typedefs.h:116:16: note: forward declaration of 'struct TranslationBlock'
>      116 | typedef struct TranslationBlock TranslationBlock;
>          |                ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/rx/cpu.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> diff --git a/target/rx/cpu.c b/target/rx/cpu.c
> index 65a74ce720..945ae6e9e5 100644
> --- a/target/rx/cpu.c
> +++ b/target/rx/cpu.c
> @@ -23,6 +23,7 @@
>   #include "migration/vmstate.h"
>   #include "exec/exec-all.h"
>   #include "exec/page-protection.h"
> +#include "exec/translation-block.h"
>   #include "hw/loader.h"
>   #include "fpu/softfloat.h"
>   #include "tcg/debug-assert.h"



  parent reply	other threads:[~2024-11-14 18:44 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14  1:12 [PATCH 00/24] exec: Build up 'cputlb.h' and 'ram_addr.h' headers Philippe Mathieu-Daudé
2024-11-14  1:12 ` [PATCH 01/24] exec/cpu-all: Include missing 'exec/cpu-defs.h' header Philippe Mathieu-Daudé
2024-11-14  4:09   ` Pierrick Bouvier
2024-11-14  8:29   ` Thomas Huth
2024-11-14 18:11     ` Richard Henderson
2024-11-14  1:12 ` [PATCH 02/24] exec/cpu-defs: Remove unnecessary headers Philippe Mathieu-Daudé
2024-11-14  4:09   ` Pierrick Bouvier
2024-11-14  8:33   ` Thomas Huth
2024-11-14 18:15   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 03/24] exec/translation-block: Include missing 'exec/vaddr.h' header Philippe Mathieu-Daudé
2024-11-14  4:10   ` Pierrick Bouvier
2024-11-14 15:23     ` Philippe Mathieu-Daudé
2024-11-14 17:13       ` Pierrick Bouvier
2024-11-14 18:15   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 04/24] accel/tcg: Include missing 'exec/translation-block.h' header Philippe Mathieu-Daudé
2024-11-14  4:11   ` Pierrick Bouvier
2024-11-14 18:23   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 05/24] target/i386/helper: " Philippe Mathieu-Daudé
2024-11-14  4:11   ` Pierrick Bouvier
2024-11-14 18:42   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 06/24] target/rx/cpu: " Philippe Mathieu-Daudé
2024-11-14  4:11   ` Pierrick Bouvier
2024-11-14 18:43   ` Richard Henderson [this message]
2024-11-14  1:12 ` [PATCH 07/24] system/watchpoint: Include missing 'exec/cpu-all.h' header Philippe Mathieu-Daudé
2024-11-14  4:11   ` Pierrick Bouvier
2024-11-14 18:53   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 08/24] linux-user/aarch64/mte: Include missing 'user/abitypes.h' header Philippe Mathieu-Daudé
2024-11-14  4:11   ` Pierrick Bouvier
2024-11-14 18:59   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 09/24] target/arm/mte: Restrict 'exec/ram_addr.h' to system emulation Philippe Mathieu-Daudé
2024-11-14  4:11   ` Pierrick Bouvier
2024-11-14 19:00   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 10/24] target/arm/cpu: Restrict cpu_untagged_addr() to user emulation Philippe Mathieu-Daudé
2024-11-14  4:12   ` Pierrick Bouvier
2024-11-14 19:03   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 11/24] exec: Introduce 'user/guest-host.h' header Philippe Mathieu-Daudé
2024-11-14  4:12   ` Pierrick Bouvier
2024-11-14 19:14   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 12/24] accel/tcg: Have tlb_vaddr_to_host() use vaddr type Philippe Mathieu-Daudé
2024-11-14  4:12   ` Pierrick Bouvier
2024-11-14 19:16   ` Richard Henderson
2024-11-14  1:12 ` [PATCH 13/24] exec: Declare tlb_reset_dirty*() in 'exec/cputlb.h' Philippe Mathieu-Daudé
2024-11-14  4:12   ` Pierrick Bouvier
2024-11-14 19:19   ` Richard Henderson
2024-11-14 21:05     ` Philippe Mathieu-Daudé
2024-11-14  1:12 ` [PATCH 14/24] exec: Declare tlb_init/destroy() " Philippe Mathieu-Daudé
2024-11-14  4:13   ` Pierrick Bouvier
2024-11-14 19:21   ` Richard Henderson
2024-11-14 21:13     ` Philippe Mathieu-Daudé
2024-11-14  1:13 ` [PATCH 15/24] exec: Declare tlb_set_page_full() " Philippe Mathieu-Daudé
2024-11-14  4:13   ` Pierrick Bouvier
2024-11-14 19:24   ` Richard Henderson
2024-11-14  1:13 ` [PATCH 16/24] exec: Declare tlb_set_page_with_attrs() " Philippe Mathieu-Daudé
2024-11-14  4:13   ` Pierrick Bouvier
2024-11-14  1:13 ` [PATCH 17/24] exec: Declare tlb_set_page() " Philippe Mathieu-Daudé
2024-11-14  4:13   ` Pierrick Bouvier
2024-11-14  1:13 ` [PATCH 18/24] exec: Declare tlb_flush*() " Philippe Mathieu-Daudé
2024-11-14  4:14   ` Pierrick Bouvier
2024-11-14 19:30   ` Richard Henderson
2024-11-14  1:13 ` [PATCH 19/24] exec: Declare tlb_hit*() " Philippe Mathieu-Daudé
2024-11-14  4:14   ` Pierrick Bouvier
2024-11-14 19:37   ` Richard Henderson
2024-11-14  1:13 ` [PATCH 20/24] exec: Declare tlb_vaddr_to_host() " Philippe Mathieu-Daudé
2024-11-14  4:14   ` Pierrick Bouvier
2024-11-14 19:59   ` Richard Henderson
2024-11-14  1:13 ` [PATCH 21/24] exec: Extract CPU physical memory API to 'sysemu/physmem-target.h' Philippe Mathieu-Daudé
2024-11-14  1:17   ` Philippe Mathieu-Daudé
2024-11-14  4:15   ` Pierrick Bouvier
2024-11-14 20:51   ` Richard Henderson
2024-11-14  1:13 ` [PATCH 22/24] exec/cpu-common: Move ram_addr_t related methods to 'exec/ram_addr.h' Philippe Mathieu-Daudé
2024-11-14  4:15   ` Pierrick Bouvier
2024-11-14 20:47   ` Richard Henderson
2024-11-14  1:13 ` [PATCH 23/24] exec/memory: Move qemu_map_ram_ptr() declaration " Philippe Mathieu-Daudé
2024-11-14  4:16   ` Pierrick Bouvier
2024-11-14 20:48   ` Richard Henderson
2024-11-14  1:13 ` [PATCH 24/24] exec: Move 'ram_addr.h' header under sysemu/ namespace Philippe Mathieu-Daudé
2024-11-14  4:16   ` Pierrick Bouvier
2024-11-14 20:49   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7d12d85-fa22-4b53-ad09-b55ae62e4d9e@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=anjo@rev.ng \
    --cc=david@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).