From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH RFC v2 07/10] target/arm: ldg on canonical tag loads the tag
Date: Mon, 17 Nov 2025 17:26:54 +0100 [thread overview]
Message-ID: <b7d5b2dd-bdb2-49f5-8345-d55d5d74a65a@linaro.org> (raw)
In-Reply-To: <20251116-feat-mte4-v2-7-9a7122b7fa76@gmail.com>
On 11/17/25 02:40, Gabriel Brookman wrote:
> @@ -444,6 +449,11 @@ uint64_t HELPER(ldgm)(CPUARMState *env, uint64_t ptr)
> return 0;
> }
>
> + if (mtx_check(env, extract64(ptr, 55, 1))) {
> + shift = extract64(ptr, LOG2_TAG_GRANULE, 4) * 4;
> + return (~0) << shift;
> + }
This should load the canonical tag, which is 0 for bit55==0.
The ~0 is wrong because it's not 64-bit.
The field also needs to be bound by gm_bs.
Something like
return MAKE_64BIT_MASK(shift, shift + (2 << gm_bs));
r~
next prev parent reply other threads:[~2025-11-17 16:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 1:40 [PATCH RFC v2 00/10] target/arm: add support for MTE4 Gabriel Brookman
2025-11-17 1:40 ` [PATCH RFC v2 01/10] target/arm: explicitly disable MTE4 for max Gabriel Brookman
2025-11-17 9:48 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 02/10] tests/tcg: added test for MTE FAR Gabriel Brookman
2025-11-17 9:51 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 03/10] target/arm: add TCSO bitmasks to SCTLR Gabriel Brookman
2025-11-17 15:14 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 04/10] target/arm: add FEAT_MTE_STORE_ONLY logic Gabriel Brookman
2025-11-17 15:26 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 05/10] tests/tcg: added test for MTE write-only Gabriel Brookman
2025-11-17 15:39 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 06/10] target/arm: add canonical and no-address tag logic Gabriel Brookman
2025-11-17 16:18 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 07/10] target/arm: ldg on canonical tag loads the tag Gabriel Brookman
2025-11-17 16:26 ` Richard Henderson [this message]
2025-11-18 17:31 ` brookmangabriel
2025-11-17 1:40 ` [PATCH RFC v2 08/10] target/arm: storing to canonical tags faults Gabriel Brookman
2025-11-19 7:48 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 09/10] tests/tcg: added test for MTE canonical and NAT Gabriel Brookman
2025-11-19 7:49 ` Richard Henderson
2025-11-17 1:40 ` [PATCH RFC v2 10/10] docs: added MTE4 features to docs Gabriel Brookman
2025-11-19 7:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7d5b2dd-bdb2-49f5-8345-d55d5d74a65a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).