From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B618AC4361B for ; Fri, 11 Dec 2020 18:38:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F32AA23F2A for ; Fri, 11 Dec 2020 18:38:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F32AA23F2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knnJB-0005OT-Ol for qemu-devel@archiver.kernel.org; Fri, 11 Dec 2020 13:38:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knn3z-0000mc-14 for qemu-devel@nongnu.org; Fri, 11 Dec 2020 13:22:43 -0500 Received: from mail-oo1-xc41.google.com ([2607:f8b0:4864:20::c41]:46154) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knn3v-0002Tz-BX for qemu-devel@nongnu.org; Fri, 11 Dec 2020 13:22:42 -0500 Received: by mail-oo1-xc41.google.com with SMTP id w9so2357560ooh.13 for ; Fri, 11 Dec 2020 10:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1c/NkRpy0Z9hC8jdMf/L4qwi/y+KFgzqq7HfbEF76FE=; b=Oyk+VYBABQ8n94h9TDEz5m2iJyn+77SpkzlSsmmR1vdAubqX/5iCGArANYwI8xlS9i Y1Zl4I0MDKkqMF8kOLigVf9RYnyMk7cqHsJQi7HIfjZlofkEk744g8m89cw2UPiGASJl AQ7bu5qVVGuxCvqGKoRG+enlQ5GfdU26RRTz0CEFNq+ao6+5Wg5vrHEZB7gfOzOaCTmh Iu+dDiqfkKUSvvZoHdyP6M7yz1/uXrk0O2WrYFxrP9bCfKRzRy0jfm1SeB6qsuzkfFeX qF0c2ehJ0RoinCHL6hDQlLDFGOVNA7g85yIYL8yePn+9HgsAickPfApsvuG1SCxtMLd+ 5LDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1c/NkRpy0Z9hC8jdMf/L4qwi/y+KFgzqq7HfbEF76FE=; b=oIrXtSi1lZfItino+wfvgLUnrXjpA85OYxXBaoqsW3vsBBt9zWm9JWew+idfdkQXqG 56fSfa/Kj62tUrRpSFdG0xH1qFWjQ0tOdJsm1wJUsQjcdef7SyU/iiOBeBehnvvkUVv0 MExv6qkN6ejjr3YQ+PWDbHVhzWf+ed9E+NzXlYKkj2t4BgjdmngtTc0GuhFc+NiF+etQ 9lsRHvw6EhhMYP47EiipLywaHmwGvA3VUmOP3rdaFTwh5eXHQ1MC8yqgYtQuFrIRXbNZ Hjqcfm8jL1GCspHiMGrJM0tYxaNqU3d85vX2yBmyD2JBCwA5JT9Wk14Aa85DGJc0i0i3 826Q== X-Gm-Message-State: AOAM5317nd7RCmmJ0/U/Dgjswc7zmBOqZeWstCV1Y6kiHSQq14R8h4lg W14eQw7Rq2PWEjvsbmWX/0jmwQ== X-Google-Smtp-Source: ABdhPJy2n38/Gs7GXnixnYvpXe18PqD+rCvZwSZqIycdM4Rv/y5yu9nWmDDIP+UyB8bkRGgPhqmRqA== X-Received: by 2002:a4a:9b16:: with SMTP id a22mr11113705ook.6.1607710956954; Fri, 11 Dec 2020 10:22:36 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id c204sm1944593oob.44.2020.12.11.10.22.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Dec 2020 10:22:36 -0800 (PST) Subject: Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops To: Claudio Fontana , Paolo Bonzini , Thomas Huth , Stefano Stabellini , Wenchao Wang , Roman Bolshakov , Sunil Muthuswamy , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20201211083143.14350-1-cfontana@suse.de> <20201211083143.14350-19-cfontana@suse.de> <78a7119d-1b4b-47dc-8f16-510708c9fcd4@linaro.org> <15b884b7-94e4-1476-f883-e84379b2661e@linaro.org> <5d9457df-c7c6-dd61-bbd7-1563d29102f8@suse.de> <946cb717-d1f3-5b30-5622-0126437420d7@suse.de> From: Richard Henderson Message-ID: Date: Fri, 11 Dec 2020 12:22:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <946cb717-d1f3-5b30-5622-0126437420d7@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c41; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc41.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Eduardo Habkost , Paul Durrant , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Jason Wang , Marcelo Tosatti , qemu-devel@nongnu.org, Peter Xu , Dario Faggioli , Cameron Esfahani , haxm-team@intel.com, Colin Xu , Anthony Perard , Bruce Rogers , Olaf Hering , "Emilio G . Cota" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/11/20 12:15 PM, Claudio Fontana wrote: > Should I return this file to the original state (without the extra #includes that pretend it to be a standalone header file, > and call it > > tcg-cpu-ops.h.inc > > ? If this header can work with qemu/typedefs.h, then no, because the circularity has been resolved. Otherwise, yes. Thanks, r~