From: Maxim Levitsky <mlevitsk@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v3 2/2] block: qcow2: remove the created file on initialization error
Date: Tue, 08 Dec 2020 17:29:07 +0200 [thread overview]
Message-ID: <b7fb21459daf73ae9fc624ae80c575cab29467e9.camel@redhat.com> (raw)
In-Reply-To: <w51wnxspbdx.fsf@maestria.local.igalia.com>
On Tue, 2020-12-08 at 16:26 +0100, Alberto Garcia wrote:
> On Tue 08 Dec 2020 03:21:59 PM CET, Maxim Levitsky wrote:
> > If the qcow initialization fails, we should remove the file if it was
> > already created, to avoid leaving stale files around.
> >
> > We already do this for luks raw images.
> >
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
>
> > ret = qcow2_co_create(create_options, errp);
> > if (ret < 0) {
> > +
> > + Error *local_delete_err = NULL;
>
> Why that empty line though?
I didn't notice. I can send a new version if this is needed.
Thanks for the review!
Best regards,
Maxim Levitsky
>
> Berto
>
next prev parent reply other threads:[~2020-12-08 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 14:21 [PATCH v3 0/2] qcow2: don't leave partially initialized file on image creation Maxim Levitsky
2020-12-08 14:21 ` [PATCH v3 1/2] crypto: luks: Fix tiny memory leak Maxim Levitsky
2020-12-08 15:25 ` Alberto Garcia
2020-12-08 14:21 ` [PATCH v3 2/2] block: qcow2: remove the created file on initialization error Maxim Levitsky
2020-12-08 15:26 ` Alberto Garcia
2020-12-08 15:29 ` Maxim Levitsky [this message]
2020-12-08 15:47 ` Vladimir Sementsov-Ogievskiy
2020-12-08 16:27 ` Maxim Levitsky
2020-12-08 16:54 ` Vladimir Sementsov-Ogievskiy
2020-12-08 17:11 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7fb21459daf73ae9fc624ae80c575cab29467e9.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).