qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>,
	"Michael S . Tsirkin" <mst@redhat.com>
Cc: Dmitry Fleytman <dmitry.fleytman@gmail.com>,
	qemu-devel@nongnu.org, Yan Vugenfirer <yan@daynix.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK
Date: Mon, 12 Nov 2018 17:25:59 +0800	[thread overview]
Message-ID: <b800852b-e81e-459c-c6e1-15d4c99fc0eb@redhat.com> (raw)
In-Reply-To: <CAOEp5Oe_TFTpQ_yBGJ-OyCw_Zne7bF0nUGV8XpG+4Fd+TJ7i8g@mail.gmail.com>


On 2018/11/12 下午4:57, Yuri Benditovich wrote:
>
> On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin <mst@redhat.com 
> <mailto:mst@redhat.com>> wrote:
>
>     On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote:
>     >     > @@ -66,12 +143,16 @@ typedef struct VirtIONet {
>     >     >      VirtIONetQueue *vqs;
>     >     >      VirtQueue *ctrl_vq;
>     >     >      NICState *nic;
>     >     > +    QTAILQ_HEAD(, NetRscChain) rsc_chains;
>     >
>     >     what exactly happens with these chains on migration?
>     >
>     >
>     > This feature (software implementation of RSC in QEMU) is
>     intended to be used in
>     > the environment of certification tests which never uses migration.
>
>     Should this feature disable migration then?
>
>
> IMO, this should not. But if you find it mandatory, please respond and 
> I will add the migration blocker.


So if my understanding is correct, it's safe to do nothing even if we 
allow migration for RSC?

Thanks

  reply	other threads:[~2018-11-12  9:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 14:58 [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK Yuri Benditovich
2018-11-09 18:11 ` Michael S. Tsirkin
2018-11-11 10:18   ` Yuri Benditovich
2018-11-12  2:54     ` Michael S. Tsirkin
2018-11-12  8:57       ` Yuri Benditovich
2018-11-12  9:25         ` Jason Wang [this message]
2018-11-12 11:31           ` Yuri Benditovich
2018-11-12 20:53             ` Michael S. Tsirkin
2018-11-13  8:21               ` Yuri Benditovich
2018-11-13 15:32                 ` Michael S. Tsirkin
2018-11-13  3:41 ` Wei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b800852b-e81e-459c-c6e1-15d4c99fc0eb@redhat.com \
    --to=jasowang@redhat.com \
    --cc=dmitry.fleytman@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).