From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11871C28B2E for ; Tue, 11 Mar 2025 07:37:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1truA7-00088L-Lw; Tue, 11 Mar 2025 03:36:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tru9v-00082q-1n for qemu-devel@nongnu.org; Tue, 11 Mar 2025 03:36:15 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tru9n-0000yg-VG for qemu-devel@nongnu.org; Tue, 11 Mar 2025 03:36:14 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-39140bd6317so1735230f8f.1 for ; Tue, 11 Mar 2025 00:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741678564; x=1742283364; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YBDtd+wGYXepiPCUvcu8NxohmXbd41Si0c1Rztrtm0M=; b=ZGTObIb6KwkgHrmD0Id8CDx326+Ic1rDzMAlv+SF+Z16idvHVCHR5qPkKg00OZyDln vOWjrKaHU6WgcPkYmoPCnHjID7BGr7RDgefTy54J8oTXBXCfUbsILrYtAsVSnWGYp0Fs QK5yQRBpGaQm3Jh6jPhHtSPmWuItG/xekMlmnrpwX9v64uJztxaVKGwTiJ8mFAmPXrMd jH0jhwmEP6SAFbNwl12czisQiSSdTEXsT/Yue21Isoc/6mZfBmW0yiVGb5LBv6lRcLFN hbQe+PldnXylNiD+x+Jgj/N0fQypgy4ExUBY3Qc2TZrY2QQM79WB/gDvk/6XaHXNc4Vd sFCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741678564; x=1742283364; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YBDtd+wGYXepiPCUvcu8NxohmXbd41Si0c1Rztrtm0M=; b=NmodzCNnFGokXg+btuKSUV4zK0Ah7WutzWNQICmb38iG3aCa0odGvs0J3fEEZ18UTI L2u7pxZNTqZEBpBPN6dtuK1RRLcnYFz+lhCTerT0BO/3+vMuYdQjrx5WvCFFyHDLw58n 7YzZDCOjmsTSg1jfiGferS0LSC0vFEdqsy7capqho25h/56NP7cM1B4vMImEX9GTncvq EayQrcY+dGS+SBUWKW/u9waZIYtqmRDMJTMXZaNzCNO28cYzRa90e4uXL/d1Z/sW5D2K X7OsjC9C+aLreZKRkWo+lq2uJkZb7eroaqHxnO5mKEn8ggVK5XXaOcaMrW5IIZJhkahp 7lYw== X-Forwarded-Encrypted: i=1; AJvYcCXQjFfgSlCmI3pheHXn43I9bQv7H7b14DCzK7HjfZSJgDyVWFhTcMnUdNOiDZT1Wkqx8nps+1PqOFHD@nongnu.org X-Gm-Message-State: AOJu0YwRVmXns+KSgIBAEEVFh7XQM2EZONIxwp8vZw/GGOClSmcdYNt4 kcQ5xN98LwJhKj/QEmlbji86TP6dOBzx2bSelCmACPhdBUKV6CuQ3696jLhQvlqXzVCxE7MmJxe saP4= X-Gm-Gg: ASbGnctYFxFZ5o9/cW+yjMPtkee6gKTIZcplP5351SiyCAnJ8QjDUJsmDFnS7vAKs5B SsxnP8F7nvtLtDx+Z1IGJ89S5Ok0vYXRH8gdF8+6hPXn/iMCBtERPmBPERxFY5m7SdzMrhwKvFN bT09TE0thx913bEbKOjEjckXB6SyQ+7pbDf/gXcQKrw8yFAg2cTpJi4LL+5yArPGNpgEORRmUHB b/pZymQEuxaStPJ5hAemg0i5oBxCZqlK2WU1m/dZHYKsZBuqCFWxwh2E1vwjMN85Z74wOZyhbQ2 cL016Fd1nS5mXliNfzBlRyV68hQp3eNRNbOzdbmZH2OdLRfWH9oUHQRibUSn2PQDogpORNHmNhB LthOZW76VjHFr9muCj0Jy43U= X-Google-Smtp-Source: AGHT+IFSPGz9/gfwsiFYEmt/RzI+9DcM9u3J2MgkQs5at33CHQLyaRLSm47Zlzsudug5b+arJ/EAbg== X-Received: by 2002:a05:6000:188b:b0:391:496b:5646 with SMTP id ffacd0b85a97d-391496b5792mr6565392f8f.28.1741678564530; Tue, 11 Mar 2025 00:36:04 -0700 (PDT) Received: from [192.168.69.199] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43cee67ae5esm91023745e9.33.2025.03.11.00.36.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 00:36:03 -0700 (PDT) Message-ID: Date: Tue, 11 Mar 2025 08:36:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/16] include/exec/memory: extract devend_big_endian from devend_memop To: Pierrick Bouvier , qemu-devel@nongnu.org Cc: Paul Durrant , Liu Zhiwei , David Hildenbrand , Weiwei Li , xen-devel@lists.xenproject.org, Paolo Bonzini , Richard Henderson , Peter Xu , Nicholas Piggin , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Stefano Stabellini , Harsh Prateek Bora , alex.bennee@linaro.org, qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org, Yoshinori Sato , Palmer Dabbelt , Daniel Henrique Barboza , Anthony PERARD References: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> <20250311040838.3937136-15-pierrick.bouvier@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250311040838.3937136-15-pierrick.bouvier@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/3/25 05:08, Pierrick Bouvier wrote: > we'll use it in system/memory.c. Having part of the commit description separated in its subject is a bit annoying. But then I'm probably using 20-years too old tools in my patch workflow. Only used in system/{memory,physmem}.c, worth move to a local system/memory-internal.h header? Or even simpler, move include/exec/memory-internal.h -> exec/memory-internal.h first. > Signed-off-by: Pierrick Bouvier > --- > include/exec/memory.h | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 60c0fb6ccd4..57661283684 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -3138,16 +3138,22 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, > MemTxResult address_space_set(AddressSpace *as, hwaddr addr, > uint8_t c, hwaddr len, MemTxAttrs attrs); > > -/* enum device_endian to MemOp. */ > -static inline MemOp devend_memop(enum device_endian end) > +/* returns true if end is big endian. */ > +static inline bool devend_big_endian(enum device_endian end) > { > QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && > DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); > > - bool big_endian = (end == DEVICE_NATIVE_ENDIAN > - ? target_words_bigendian() > - : end == DEVICE_BIG_ENDIAN); > - return big_endian ? MO_BE : MO_LE; > + if (end == DEVICE_NATIVE_ENDIAN) { > + return target_words_bigendian(); > + } > + return end == DEVICE_BIG_ENDIAN; > +} > + > +/* enum device_endian to MemOp. */ > +static inline MemOp devend_memop(enum device_endian end) > +{ > + return devend_big_endian(end) ? MO_BE : MO_LE; > } > > /*