* [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization
@ 2018-01-18 10:58 Liang Li
2018-01-18 11:39 ` Vladimir Sementsov-Ogievskiy
2018-01-31 18:54 ` Max Reitz
0 siblings, 2 replies; 5+ messages in thread
From: Liang Li @ 2018-01-18 10:58 UTC (permalink / raw)
To: vsementsov, famz, mreitz; +Cc: qemu-devel
The .count of HBitmap is forgot to set in function
hbitmap_deserialize_finish, let's set it to the right value.
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Fam Zheng <famz@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: John Snow <jsnow@redhat.com>
Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Signed-off-by: Liang Li <liliangleo@didichuxing.com>
---
util/hbitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/hbitmap.c b/util/hbitmap.c
index 289778a..58a2c93 100644
--- a/util/hbitmap.c
+++ b/util/hbitmap.c
@@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
}
bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
+ bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
}
void hbitmap_free(HBitmap *hb)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization
2018-01-18 10:58 [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization Liang Li
@ 2018-01-18 11:39 ` Vladimir Sementsov-Ogievskiy
2018-01-31 18:54 ` Max Reitz
1 sibling, 0 replies; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-01-18 11:39 UTC (permalink / raw)
To: Liang Li, famz, mreitz; +Cc: qemu-devel
18.01.2018 13:58, Liang Li wrote:
> The .count of HBitmap is forgot to set in function
> hbitmap_deserialize_finish, let's set it to the right value.
>
> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: John Snow <jsnow@redhat.com>
> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> Signed-off-by: Liang Li <liliangleo@didichuxing.com>
> ---
> util/hbitmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/hbitmap.c b/util/hbitmap.c
> index 289778a..58a2c93 100644
> --- a/util/hbitmap.c
> +++ b/util/hbitmap.c
> @@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
> }
>
> bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
> + bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
> }
>
> void hbitmap_free(HBitmap *hb)
Hm, right, my fault. Thank you!
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization
2018-01-18 10:58 [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization Liang Li
2018-01-18 11:39 ` Vladimir Sementsov-Ogievskiy
@ 2018-01-31 18:54 ` Max Reitz
2018-01-31 19:01 ` John Snow
1 sibling, 1 reply; 5+ messages in thread
From: Max Reitz @ 2018-01-31 18:54 UTC (permalink / raw)
To: Liang Li, vsementsov, famz; +Cc: qemu-devel, Qemu-block, John Snow
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On 2018-01-18 11:58, Liang Li wrote:
> The .count of HBitmap is forgot to set in function
> hbitmap_deserialize_finish, let's set it to the right value.
>
> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: John Snow <jsnow@redhat.com>
> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> Signed-off-by: Liang Li <liliangleo@didichuxing.com>
> ---
> util/hbitmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/hbitmap.c b/util/hbitmap.c
> index 289778a..58a2c93 100644
> --- a/util/hbitmap.c
> +++ b/util/hbitmap.c
> @@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
> }
>
> bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
> + bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
> }
>
> void hbitmap_free(HBitmap *hb)
Actually CC-ing John...
(Looks good to me, though.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization
2018-01-31 18:54 ` Max Reitz
@ 2018-01-31 19:01 ` John Snow
2018-01-31 19:05 ` Max Reitz
0 siblings, 1 reply; 5+ messages in thread
From: John Snow @ 2018-01-31 19:01 UTC (permalink / raw)
To: Max Reitz, Liang Li, vsementsov, famz; +Cc: qemu-devel, Qemu-block
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
On 01/31/2018 01:54 PM, Max Reitz wrote:
> On 2018-01-18 11:58, Liang Li wrote:
>> The .count of HBitmap is forgot to set in function
>> hbitmap_deserialize_finish, let's set it to the right value.
>>
>> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> Cc: Fam Zheng <famz@redhat.com>
>> Cc: Max Reitz <mreitz@redhat.com>
>> Cc: John Snow <jsnow@redhat.com>
>> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
>> Signed-off-by: Liang Li <liliangleo@didichuxing.com>
>> ---
>> util/hbitmap.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/util/hbitmap.c b/util/hbitmap.c
>> index 289778a..58a2c93 100644
>> --- a/util/hbitmap.c
>> +++ b/util/hbitmap.c
>> @@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
>> }
>>
>> bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
>> + bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
>> }
>>
>> void hbitmap_free(HBitmap *hb)
>
> Actually CC-ing John...
>
> (Looks good to me, though.)
>
> Max
>
Staged already, sorry. Will send the PR this Friday.
https://github.com/jnsnow/qemu/commit/78ad6913bd34a54f658d5182990fe149614d6402
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization
2018-01-31 19:01 ` John Snow
@ 2018-01-31 19:05 ` Max Reitz
0 siblings, 0 replies; 5+ messages in thread
From: Max Reitz @ 2018-01-31 19:05 UTC (permalink / raw)
To: John Snow, Liang Li, vsementsov, famz; +Cc: qemu-devel, Qemu-block
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
On 2018-01-31 20:01, John Snow wrote:
>
>
> On 01/31/2018 01:54 PM, Max Reitz wrote:
>> On 2018-01-18 11:58, Liang Li wrote:
>>> The .count of HBitmap is forgot to set in function
>>> hbitmap_deserialize_finish, let's set it to the right value.
>>>
>>> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>> Cc: Fam Zheng <famz@redhat.com>
>>> Cc: Max Reitz <mreitz@redhat.com>
>>> Cc: John Snow <jsnow@redhat.com>
>>> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
>>> Signed-off-by: Liang Li <liliangleo@didichuxing.com>
>>> ---
>>> util/hbitmap.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/util/hbitmap.c b/util/hbitmap.c
>>> index 289778a..58a2c93 100644
>>> --- a/util/hbitmap.c
>>> +++ b/util/hbitmap.c
>>> @@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
>>> }
>>>
>>> bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
>>> + bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
>>> }
>>>
>>> void hbitmap_free(HBitmap *hb)
>>
>> Actually CC-ing John...
>>
>> (Looks good to me, though.)
>>
>> Max
>>
>
> Staged already, sorry. Will send the PR this Friday.
>
> https://github.com/jnsnow/qemu/commit/78ad6913bd34a54f658d5182990fe149614d6402
OK, good. :-)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-31 19:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-18 10:58 [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization Liang Li
2018-01-18 11:39 ` Vladimir Sementsov-Ogievskiy
2018-01-31 18:54 ` Max Reitz
2018-01-31 19:01 ` John Snow
2018-01-31 19:05 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).