From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25AE4C43603 for ; Wed, 4 Dec 2019 14:42:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7C6F205F4 for ; Wed, 4 Dec 2019 14:42:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QnAlIA3f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7C6F205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icVrZ-0007rV-2C for qemu-devel@archiver.kernel.org; Wed, 04 Dec 2019 09:42:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45385) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icVqi-0007Jl-TQ for qemu-devel@nongnu.org; Wed, 04 Dec 2019 09:41:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icVqh-0006cQ-SY for qemu-devel@nongnu.org; Wed, 04 Dec 2019 09:41:52 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:31176 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icVqh-0006cF-P9 for qemu-devel@nongnu.org; Wed, 04 Dec 2019 09:41:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575470510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OJEIQPrEsxkvvNG9Qd4bPxGqYZkE6elT9GXs9ePojJc=; b=QnAlIA3f30lOmwBXp4cs+Esr0C4DILkYM9bsEgqPJH42Oy+LlxG0WKf+1bqoXA6gvJGUiz MtAWtyY7ma5pnCFu8TsXqvOUm3c+ms55iSAKmARMqpAaS7dTBXXzaDlAdR+d2uQkEzBo1V 5A2lAxdZM/SI7/s138A4NCdN3Xr0YHI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-Jng4xPMqPkW0Yfgf2VPglQ-1; Wed, 04 Dec 2019 09:41:48 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19E55102CE26; Wed, 4 Dec 2019 14:41:46 +0000 (UTC) Received: from [10.3.116.171] (ovpn-116-171.phx2.redhat.com [10.3.116.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3120E5D9C5; Wed, 4 Dec 2019 14:41:38 +0000 (UTC) Subject: Re: [PATCH v2 3/3] virtio-serial-bus: fix memory leak while attach virtio-serial-bus To: pannengyuan@huawei.com, mst@redhat.com References: <1575444716-17632-1-git-send-email-pannengyuan@huawei.com> <1575444716-17632-3-git-send-email-pannengyuan@huawei.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 4 Dec 2019 08:41:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1575444716-17632-3-git-send-email-pannengyuan@huawei.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: Jng4xPMqPkW0Yfgf2VPglQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liyiting@huawei.com, Laurent Vivier , zhang.zhanghailiang@huawei.com, kuhn.chenqun@huawei.com, Amit Shah , qemu-devel@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/4/19 1:31 AM, pannengyuan@huawei.com wrote: > From: Pan Nengyuan >=20 > ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in s/is // > virtio_serial_device_unrealize, the memory leak stack is as bellow: below >=20 > Direct leak of 1290240 byte(s) in 180 object(s) allocated from: > #0 0x7fc9bfc27560 in calloc (/usr/lib64/libasan.so.3+0xc7560) > #1 0x7fc9bed6f015 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x50015) > #2 0x5650e02b83e7 in virtio_add_queue hw/virtio/virtio.c:2327 > #3 0x5650e02847b5 in virtio_serial_device_realize hw/char/virtio-ser= ial-bus.c:1089 > #4 0x5650e02b56a7 in virtio_device_realize hw/virtio/virtio.c:3504 > #5 0x5650e03bf031 in device_set_realized hw/core/qdev.c:876 > #6 0x5650e0531efd in property_set_bool qom/object.c:2080 > #7 0x5650e053650e in object_property_set_qobject qom/qom-qobject.c:2= 6 > #8 0x5650e0533e14 in object_property_set_bool qom/object.c:1338 > #9 0x5650e04c0e37 in virtio_pci_realize hw/virtio/virtio-pci.c:1801 >=20 > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > Cc: Laurent Vivier > Cc: Amit Shah > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > --- --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org