qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-trivial@nongnu.org,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] meson.build: Bump minimum supported version of pixman to 0.34.0
Date: Wed, 11 May 2022 12:56:45 +0200	[thread overview]
Message-ID: <b819e229-4aff-6381-a686-664aa97712a3@redhat.com> (raw)
In-Reply-To: <CAFEAcA9bUires+a-dc8v-oDDKg5WJRf4vVR8jKady5QgjMJTZA@mail.gmail.com>

On 11/05/2022 12.28, Peter Maydell wrote:
> On Wed, 11 May 2022 at 10:50, Thomas Huth <thuth@redhat.com> wrote:
>>
>> We haven't revisited the minimum required versions of pixman
>> since quite a while. Let's check whether we can rule out some
>> old versions that nobody tests anymore...
>>
>> For pixman, per repology.org, currently shipping versions are:
>>
>>       CentOS 8 / RHEL-8 : 0.38.4
>>                Fedora 34: 0.40.0
>>               Debian 10 : 0.36.0
>>        Ubuntu LTS 20.04 : 0.38.4
>>      openSUSE Leap 15.3 : 0.34.0
>>             MSYS2 MinGW : 0.40.0
>>           FreeBSD Ports : 0.34.0 / 0.40.0
>>            NetBSD pksrc : 0.40.0
>>
>> OpenBSD 7.1 seems to use 0.40.0 when running tests/vm/openbsd.
>>
>> So it seems to be fine to bump the minimum version to 0.34.0 now.
> 
> This seems to be missing the rationale for why bumping
> the minimum version is worth doing. What new feature that
> we need is this enabling, or what now-unnecessary bug
> workarounds does this permit us to drop?

We simply don't test such old versions anymore. Thus what happens if someone 
tries to use such a version and runs into a problem (especially if it is 
non-obvious and would need a lot of debugging)? Are you still willing to fix 
it? Or would you then rather bump the version after hours of debugging the 
problem? ... IMHO it's better to set the expectations right from the start. 
If we do not test and support it anymore, we should not give the impression 
that QEMU can still be compiled with this.

  Thomas



  reply	other threads:[~2022-05-11 10:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  9:47 [PATCH] meson.build: Bump minimum supported version of pixman to 0.34.0 Thomas Huth
2022-05-11 10:28 ` Peter Maydell
2022-05-11 10:56   ` Thomas Huth [this message]
2022-05-11 11:22     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b819e229-4aff-6381-a686-664aa97712a3@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).