From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 1/3] hw/rtc/mc146818rtc: Rename RTCState -> MC146818RtcState
Date: Sat, 11 Feb 2023 14:00:36 -1000 [thread overview]
Message-ID: <b82afa34-3290-668d-fa98-7a0e6042397d@linaro.org> (raw)
In-Reply-To: <20230210233116.80311-2-philmd@linaro.org>
On 2/10/23 13:31, Philippe Mathieu-Daudé wrote:
> RTCState only represents a Motorola MC146818 model,
> not any RTC chipset. Rename the structure as MC146818RtcState
> using:
>
> $ sed -i -e s/RTCState/MC146818RtcState/g $(git grep -wl RTCState)
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> hw/isa/piix4.c | 2 +-
> hw/isa/vt82c686.c | 2 +-
> hw/rtc/mc146818rtc.c | 116 +++++++++++++++++------------------
> include/hw/rtc/mc146818rtc.h | 6 +-
> 4 files changed, 63 insertions(+), 63 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-02-12 0:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 23:31 [PATCH 0/3] hw/rtc: Rename RTCState -> MC146818RtcState and adapt API Philippe Mathieu-Daudé
2023-02-10 23:31 ` [PATCH 1/3] hw/rtc/mc146818rtc: Rename RTCState -> MC146818RtcState Philippe Mathieu-Daudé
2023-02-12 0:00 ` Richard Henderson [this message]
2023-02-10 23:31 ` [PATCH 2/3] hw/rtc/mc146818rtc: Pass MC146818RtcState instead of ISADevice argument Philippe Mathieu-Daudé
2023-02-12 0:02 ` Richard Henderson
2023-02-10 23:31 ` [PATCH 3/3] hw/rtc: Rename rtc_[get|set]_memory -> mc146818rtc_[get|set]_cmos_data Philippe Mathieu-Daudé
2023-02-12 0:08 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b82afa34-3290-668d-fa98-7a0e6042397d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=eduardo@habkost.net \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).