From: Eric Blake <eblake@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 4/4] qemu-iotests: 044: remove inaccurate docstring class description
Date: Fri, 27 Sep 2019 11:48:56 -0500 [thread overview]
Message-ID: <b82efd5e-4ecd-25af-e716-cab0d454acf8@redhat.com> (raw)
In-Reply-To: <20190927141728.7137-5-crosa@redhat.com>
On 9/27/19 9:17 AM, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/qemu-iotests/044 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044
> index eb42df0fe1..0ca4bcfc6d 100755
> --- a/tests/qemu-iotests/044
> +++ b/tests/qemu-iotests/044
> @@ -34,7 +34,6 @@ if sys.version_info.major == 2:
> test_img = os.path.join(iotests.test_dir, 'test.img')
>
> class TestRefcountTableGrowth(iotests.QMPTestCase):
> - '''Abstract base class for image mirroring test cases'''
>
Should we replace it with something useful? But this isn't meant to be
reused outside this test, so it doesn't hurt to have no documentation.
Reviewed-by: Eric Blake <eblake@redhat.com>
> def preallocate(self, name):
> fd = open(name, "r+b")
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-09-27 17:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 14:17 [PATCH 0/4] iotests: trivial cleanups Cleber Rosa
2019-09-27 14:17 ` [PATCH 1/4] qemu-iotests: remove bash shebang from library files Cleber Rosa
2019-09-27 16:37 ` Eric Blake
2019-10-09 16:26 ` Cleber Rosa
2019-10-09 18:38 ` Cleber Rosa
2019-09-27 14:17 ` [PATCH 2/4] qemu-iotests: remove forceful execution success " Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 14:17 ` [PATCH 3/4] qemu-iotests: 044: pass is actually a noop, so remove it Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 20:37 ` John Snow
2019-09-27 14:17 ` [PATCH 4/4] qemu-iotests: 044: remove inaccurate docstring class description Cleber Rosa
2019-09-27 16:48 ` Eric Blake [this message]
2019-09-27 20:38 ` John Snow
2019-10-07 13:09 ` [PATCH 0/4] iotests: trivial cleanups Max Reitz
2019-10-09 16:27 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b82efd5e-4ecd-25af-e716-cab0d454acf8@redhat.com \
--to=eblake@redhat.com \
--cc=crosa@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).