From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, jsnow@redhat.com, pbonzini@redhat.com,
armbru@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM
Date: Wed, 12 Jul 2017 10:52:52 -0500 [thread overview]
Message-ID: <b836f508-4d94-3a6a-058f-756d3d7acbc7@redhat.com> (raw)
In-Reply-To: <1499864249-26305-7-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On 07/12/2017 07:57 AM, Kevin Wolf wrote:
> If no drive=... option is passed (for an empty drive), we don't only
> lack the BlockBackend normally created by parse_drive(), but we also
> need to manually call blk_attach_dev().
>
> IDE does not support hot unplug, but if it did, qdev would take care to
> call the matching blk_detach_dev() on unplug.
>
> This fixes at least the bug that such devices didn't show up in
> query-block, and probably some more problems.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/ide/qdev.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-07-12 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 12:57 [Qemu-devel] [PATCH 0/9] block: -device drive=<node-name> fixes Kevin Wolf
2017-07-12 12:57 ` [Qemu-devel] [PATCH 1/9] block: Make blk_get_attached_dev_id() public Kevin Wolf
2017-07-12 14:53 ` Eric Blake
2017-07-12 12:57 ` [Qemu-devel] [PATCH 2/9] block/qapi: Add qdev device name to query-block Kevin Wolf
2017-07-12 15:06 ` Eric Blake
2017-07-12 12:57 ` [Qemu-devel] [PATCH 3/9] block: Make blk_all_next() public Kevin Wolf
2017-07-12 15:25 ` Eric Blake
2017-07-12 12:57 ` [Qemu-devel] [PATCH 4/9] block/qapi: Use blk_all_next() for query-block Kevin Wolf
2017-07-12 15:27 ` Eric Blake
2017-07-12 12:57 ` [Qemu-devel] [PATCH 5/9] block: List anonymous device BBs in query-block Kevin Wolf
2017-07-12 15:47 ` Eric Blake
2017-07-13 11:25 ` Kevin Wolf
2017-07-12 12:57 ` [Qemu-devel] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM Kevin Wolf
2017-07-12 15:52 ` Eric Blake [this message]
2017-07-12 12:57 ` [Qemu-devel] [PATCH 7/9] scsi-disk: " Kevin Wolf
2017-07-12 15:58 ` Eric Blake
2017-07-12 12:57 ` [Qemu-devel] [PATCH 8/9] qemu-iotests: Test 'info block' Kevin Wolf
2017-07-12 16:22 ` Eric Blake
2017-07-12 12:57 ` [Qemu-devel] [PATCH 9/9] qemu-iotests: Test unplug of -device without drive Kevin Wolf
2017-07-12 16:23 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b836f508-4d94-3a6a-058f-756d3d7acbc7@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).