From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Viktor Prutyanov <viktor.prutyanov@phystech.edu>,
kwolf@redhat.com, hreitz@redhat.com, sw@weilnetz.de,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v3] block/file-win32: add reopen handlers
Date: Wed, 18 Aug 2021 00:29:03 +0200 [thread overview]
Message-ID: <b83aa7b2-c3c1-3c33-fcdc-27bf4f2f2117@redhat.com> (raw)
In-Reply-To: <20210817202115.16771-1-viktor.prutyanov@phystech.edu>
On 8/17/21 10:21 PM, Viktor Prutyanov wrote:
> Make 'qemu-img commit' work on Windows.
>
> Command 'commit' requires reopening backing file in RW mode. So,
> add reopen prepare/commit/abort handlers and change dwShareMode
> for CreateFile call in order to allow further read/write reopening.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/418
> Suggested-by: Hanna Reitz <hreitz@redhat.com>
> Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
> ---
> v2:
> - fix indentation in raw_reopen_prepare
> - free rs if raw_reopen_prepare fails
> v3:
> - restore suggested-by field missed in v2
>
> block/file-win32.c | 90 +++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 89 insertions(+), 1 deletion(-)
LGTM, asked Helge Konetzka for testing (on the gitlab issue).
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-08-17 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 20:21 [PATCH v3] block/file-win32: add reopen handlers Viktor Prutyanov
2021-08-17 22:29 ` Philippe Mathieu-Daudé [this message]
2021-08-18 10:22 ` Helge Konetzka
2021-08-19 12:51 ` Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b83aa7b2-c3c1-3c33-fcdc-27bf4f2f2117@redhat.com \
--to=philmd@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=viktor.prutyanov@phystech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).