From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Warner Losh" <imp@bsdimp.com>
Cc: Kyle Evans <kevans@freebsd.org>, Thomas Huth <thuth@redhat.com>,
Alex Richardson <arichardson@freebsd.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 11/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future
Date: Fri, 23 Apr 2021 16:00:27 -0700 [thread overview]
Message-ID: <b8411b57-ef13-6ccd-8d55-e5cd34c30ea9@linaro.org> (raw)
In-Reply-To: <4332e51b-323d-ad82-4122-686f9929842d@amsat.org>
On 4/23/21 3:08 PM, Philippe Mathieu-Daudé wrote:
> On 4/23/21 11:38 PM, Warner Losh wrote:
>> On Fri, Apr 23, 2021 at 3:23 PM Philippe Mathieu-Daudé <f4bug@amsat.org
>> <mailto:f4bug@amsat.org>> wrote:
>>
>> On 4/23/21 10:39 PM, imp@bsdimp.com <mailto:imp@bsdimp.com> wrote:
>> > From: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>>
>> >
>> > Signed-off-by: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>>
>> > ---
>> > bsd-user/elfload.c | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
>> > index 87154283ef..07a00ddbd5 100644
>> > --- a/bsd-user/elfload.c
>> > +++ b/bsd-user/elfload.c
>> > @@ -1270,7 +1270,7 @@ int load_elf_binary(struct linux_binprm
>> *bprm, struct target_pt_regs *regs,
>> > ibcs2_interpreter = 1;
>> > }
>> >
>> > -#if 0
>> > +#ifdef notyet
>>
>> Better describe in the cover letter "ignored checkpatch errors" and keep
>> this unmodified rather than trying to bypass them by dubious code style
>> IMO. The checkpatch.pl <http://checkpatch.pl> script is here to help
>> us ;)
>>
>>
>> This one I honestly was unsure about. To be honest, it's fear that kept
>> me keeping this code.... Maybe it would be even better to just delete
>> this code entirely. I have a working final state to pull from, now that I
>> think about it to forumlate a reply, so maybe that would be even
>> better?
>
> Personally I find it simpler. We use git, so we have the history in
> the repository, can look at it and restore it if needed. This code
> is dead since years.
>
> Let's see what others think about this.
Definitely better to remove. We can review the new code more easily that way.
r~
next prev parent reply other threads:[~2021-04-23 23:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 20:39 [PULL 10/24] bsd-user: style tweak: use C not C++ comments imp
2021-04-23 20:39 ` [PULL 11/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future imp
2021-04-23 21:23 ` Philippe Mathieu-Daudé
2021-04-23 21:38 ` Warner Losh
2021-04-23 22:08 ` Philippe Mathieu-Daudé
2021-04-23 23:00 ` Richard Henderson [this message]
2021-04-23 20:39 ` [PULL 12/24] " imp
2021-04-23 20:39 ` [PULL 13/24] " imp
2021-04-23 20:39 ` [PULL 14/24] " imp
2021-04-23 20:39 ` [PULL 15/24] bsd-user: Fix commentary issues imp
2021-04-23 23:07 ` Richard Henderson
2021-04-26 8:56 ` Daniel P. Berrangé
2021-04-26 9:12 ` Peter Maydell
2021-04-26 15:10 ` Warner Losh
2021-04-23 20:39 ` [PULL 16/24] bsd-user: Use preferred block comments imp
2021-04-23 23:07 ` Richard Henderson
2021-04-23 20:39 ` [PULL 17/24] bsd-user: move extern to header file imp
2021-04-23 23:29 ` Richard Henderson
2021-04-23 20:39 ` [PULL 18/24] bsd-user: style changes for {} imp
2021-04-23 23:15 ` Richard Henderson
2021-04-23 20:39 ` [PULL 19/24] bsd-user: use qemu_strtol in preference to strtol imp
2021-04-23 21:16 ` Philippe Mathieu-Daudé
2021-04-23 21:21 ` Warner Losh
2021-04-23 20:39 ` [PULL 20/24] bsd-user: introduce host_os.h for bsd-specific code and defaults imp
2021-04-23 23:16 ` Richard Henderson
2021-04-23 20:39 ` [PULL 21/24] bsd-user: add arm target_signal.h imp
2021-04-23 23:19 ` Richard Henderson
2021-04-23 23:47 ` Warner Losh
2021-04-23 20:39 ` [PULL 22/24] bsd-user: create target_arch_cpu.h imp
2021-04-23 23:21 ` Richard Henderson
2021-04-23 20:39 ` [PULL 23/24] bsd-user: move x86 (i386 and x86_64) cpu_loop to target_arch_cpu.h imp
2021-04-23 23:23 ` Richard Henderson
2021-04-23 20:39 ` [PULL 24/24] bsd-user: move sparc cpu_loop into target_arch_cpu.h as target_cpu_loop imp
2021-04-23 23:25 ` Richard Henderson
2021-04-23 23:06 ` [PULL 10/24] bsd-user: style tweak: use C not C++ comments Richard Henderson
2021-04-23 23:44 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8411b57-ef13-6ccd-8d55-e5cd34c30ea9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=arichardson@freebsd.org \
--cc=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).