From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CCAC4338F for ; Fri, 6 Aug 2021 07:33:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF3F560F25 for ; Fri, 6 Aug 2021 07:33:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF3F560F25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBuMS-000853-NM for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 03:33:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBuLZ-00073p-Pm for qemu-devel@nongnu.org; Fri, 06 Aug 2021 03:32:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBuLY-0008Na-CQ for qemu-devel@nongnu.org; Fri, 06 Aug 2021 03:32:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628235167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CKd2Kox4c8vbFsaeJdA49twpf4BNzMGjLVo/+5u5Cxo=; b=h9xWv7EpH2AtdHGiqxs6HrFPiIkDNvSpA3kfbfwNkTLuNhmqkNcdkWtNF0vQvZqjJcC7VB b4mn1Q/eIyhoXUFkirw4CWDy4Xa0gtLVqdYB2LpBtLJFc/nXCSb5X7yZd9/JN2507obA0W J8f+tMq6BuPwVwuSHTpnJvKTpG6KwME= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-2I6ZWRfcMyyQ5udfajEYUw-1; Fri, 06 Aug 2021 03:32:46 -0400 X-MC-Unique: 2I6ZWRfcMyyQ5udfajEYUw-1 Received: by mail-wr1-f71.google.com with SMTP id j16-20020a5d44900000b02901549fdfd4fcso2870506wrq.6 for ; Fri, 06 Aug 2021 00:32:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CKd2Kox4c8vbFsaeJdA49twpf4BNzMGjLVo/+5u5Cxo=; b=S6Fz2WzVnd4HkJYbZfZRt3lIMzeLh7KeZtW0f8v/CcuWQ7jtETDG8FoQpeaPJaELkP wJOZ8LkiVzfvsIJEV71Mcoo2yzprg8n5Id9bnqsOVpRwX+Lopy8wYzbdRJXjCJo5rqsV Me+StRsUAN2gA6RxfWYaDPdKhHFOxrGVdxI+n//HUX0Jsc1IV+SaHSukXsWFQbSqBsH7 nI3Xr6QkM/sYwEn3I9jljznadH0Yu0TOOvCV8ZsR3oSYegaCx0bwCu7sfhPw+LkA4AMj sBdsr/pu52igjHJDQrRcMuIldaARwlusHhA0gwQimv66t2es9ZpjFiL/1Kd+1MnzaeU8 NnFA== X-Gm-Message-State: AOAM533/oa6qItMHsEmoiax/EsNElhwhwzEA2EQKG+1ZBpCVS1uVNISc MIy4LHHpsfZt6hDc5nv1/sH44z/RQkWtrJPf/F5+myl7HB41L1UNpBPJZIOnu1O5PSGhBezfa0a +qm597cDSmGMaO0s= X-Received: by 2002:a1c:ed03:: with SMTP id l3mr1746007wmh.56.1628235165398; Fri, 06 Aug 2021 00:32:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUOCF4z7kj0HwvBQCBxAuWurd30g0FKpyye7/QUdUEnG4RxQ6tBZpzVFyT/vC7iAbuLoy9WQ== X-Received: by 2002:a1c:ed03:: with SMTP id l3mr1745985wmh.56.1628235165233; Fri, 06 Aug 2021 00:32:45 -0700 (PDT) Received: from thuth.remote.csb (dynamic-046-114-147-107.46.114.pool.telefonica.de. [46.114.147.107]) by smtp.gmail.com with ESMTPSA id o34sm11054109wms.10.2021.08.06.00.32.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Aug 2021 00:32:44 -0700 (PDT) Subject: Re: [PATCH v1 06/12] s390x/mmu_helper: fixup mmu_translate() documentation To: David Hildenbrand , qemu-devel@nongnu.org References: <20210805152804.100333-1-david@redhat.com> <20210805152804.100333-7-david@redhat.com> From: Thomas Huth Message-ID: Date: Fri, 6 Aug 2021 09:32:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805152804.100333-7-david@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.132, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason J . Herne" , Janosch Frank , Cornelia Huck , Richard Henderson , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Claudio Imbrenda Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/08/2021 17.27, David Hildenbrand wrote: > Looks like we forgot to adjust documentation of one parameter. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c > index 167f1b1455..ca25dadb5b 100644 > --- a/target/s390x/mmu_helper.c > +++ b/target/s390x/mmu_helper.c > @@ -374,7 +374,8 @@ static void mmu_handle_skey(target_ulong addr, int rw, int *flags) > * @param asc address space control (one of the PSW_ASC_* modes) > * @param raddr the translated address is stored to this pointer > * @param flags the PAGE_READ/WRITE/EXEC flags are stored to this pointer > - * @param exc true = inject a program check if a fault occurred > + * @param tec the translation exception code if stored to this pointer if > + * there is an exception to raise > * @return 0 = success, != 0, the exception to raise > */ > int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc, > Reviewed-by: Thomas Huth