From: John Snow <jsnow@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"David Edmondson" <dme@dme.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax
Date: Tue, 26 Jan 2021 19:14:36 -0500 [thread overview]
Message-ID: <b8557f1c-a182-fe3a-3bb6-0278a1f11fba@redhat.com> (raw)
In-Reply-To: <20210121093944.GE3125227@redhat.com>
On 1/21/21 4:39 AM, Daniel P. Berrangé wrote:
> On Wed, Jan 20, 2021 at 03:12:41PM -0500, Eduardo Habkost wrote:
>> The ordering semantics of +feature/-feature is tricky and not
>> obvious, and it requires a custom option parser. Deprecate that
>> syntax so we can eventually remove the custom -cpu option parser
>> and plus_features/minus_features global variables in i386.
>>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>> ---
>> docs/system/deprecated.rst | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>
> Ideally we would also print a warning on stderr when this deprecated
> style is used.
>
+1.
It might break some tests to do that, though, but if it's not too
gruesome it's probably worth it.
next prev parent reply other threads:[~2021-01-27 0:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 14:22 [RFC PATCH 0/2] x86 CPU feature +/- fiddling and +kvm-no-defaults David Edmondson
2021-01-19 14:22 ` [RFC PATCH 1/2] hw/i386: -cpu model, -feature, +feature should enable feature David Edmondson
2021-01-19 15:20 ` [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature " Eduardo Habkost
2021-01-19 16:27 ` [External] : " David Edmondson
2021-01-19 16:30 ` Eduardo Habkost
2021-01-20 9:59 ` Igor Mammedov
2021-01-20 10:08 ` David Edmondson
2021-01-20 10:08 ` [External] : " Daniel P. Berrangé
2021-01-20 10:17 ` David Edmondson
2021-01-20 16:18 ` Eduardo Habkost
2021-01-20 19:21 ` Igor Mammedov
2021-01-20 20:12 ` [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax Eduardo Habkost
2021-01-20 20:19 ` [PATCH] docs/system: Deprecate `-cpu ..., +feature, -feature` syntax David Edmondson
2021-01-21 9:39 ` [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax Daniel P. Berrangé
2021-01-27 0:14 ` John Snow [this message]
2021-01-21 10:25 ` Igor Mammedov
2021-01-19 14:22 ` [RFC PATCH 2/2] target/i386: Add "-cpu +kvm-no-defaults" David Edmondson
2021-01-19 16:28 ` [RFC PATCH 0/2] x86 CPU feature +/- fiddling and +kvm-no-defaults Daniel P. Berrangé
2021-01-19 16:35 ` Eduardo Habkost
2021-01-19 16:41 ` Daniel P. Berrangé
2021-01-20 10:01 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8557f1c-a182-fe3a-3bb6-0278a1f11fba@redhat.com \
--to=jsnow@redhat.com \
--cc=berrange@redhat.com \
--cc=dme@dme.org \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).