From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09442C433E0 for ; Wed, 27 Jan 2021 00:16:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 570BB20679 for ; Wed, 27 Jan 2021 00:16:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 570BB20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4YVD-0008ID-2h for qemu-devel@archiver.kernel.org; Tue, 26 Jan 2021 19:16:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4YU3-0007qU-Qa for qemu-devel@nongnu.org; Tue, 26 Jan 2021 19:14:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l4YU1-0007uO-0B for qemu-devel@nongnu.org; Tue, 26 Jan 2021 19:14:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611706490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2PLOVEcgtkv/ZEhfAdngXfuEYuw655VQOSfC0WG5o1Y=; b=Z3LhUHc3bU7NXmgIzLcYV1qi/5YgEfnwB23k1a0mRLUaXTgU/ZKzy1NfKP3sfad6HEc/dF 84inW5KaI5AMIpDQJEdKCIi1SXFF41fMqRfuW/mdT9kucjQBUskgM6zDEdEJOAgAbCaZcK /I78T2d2tGRSG3xgaAsn1Ooav7MSV+4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-PiKlyiLBNwC3xiYRWqixiA-1; Tue, 26 Jan 2021 19:14:49 -0500 X-MC-Unique: PiKlyiLBNwC3xiYRWqixiA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D15E21005D44; Wed, 27 Jan 2021 00:14:45 +0000 (UTC) Received: from [10.10.112.247] (ovpn-112-247.rdu2.redhat.com [10.10.112.247]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53A466F80A; Wed, 27 Jan 2021 00:14:37 +0000 (UTC) Subject: Re: [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax To: Eduardo Habkost References: <20210119142207.3443123-1-david.edmondson@oracle.com> <20210119142207.3443123-2-david.edmondson@oracle.com> <20210119152056.GE1227584@habkost.net> <20210119163052.GG1227584@habkost.net> <20210120100803.GF3015589@redhat.com> <20210120161801.GP1227584@habkost.net> <20210120202134.4e0c4523@redhat.com> <20210120201241.GR1227584@habkost.net> <20210121093944.GE3125227@redhat.com> From: John Snow Message-ID: Date: Tue, 26 Jan 2021 19:14:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210121093944.GE3125227@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , David Edmondson , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Igor Mammedov , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/21/21 4:39 AM, Daniel P. Berrangé wrote: > On Wed, Jan 20, 2021 at 03:12:41PM -0500, Eduardo Habkost wrote: >> The ordering semantics of +feature/-feature is tricky and not >> obvious, and it requires a custom option parser. Deprecate that >> syntax so we can eventually remove the custom -cpu option parser >> and plus_features/minus_features global variables in i386. >> >> Signed-off-by: Eduardo Habkost >> --- >> docs/system/deprecated.rst | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) > > Ideally we would also print a warning on stderr when this deprecated > style is used. > +1. It might break some tests to do that, though, but if it's not too gruesome it's probably worth it.