* [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1
@ 2023-05-06 18:34 Marcin Juszkiewicz
2023-05-12 14:50 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Marcin Juszkiewicz @ 2023-05-06 18:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, Leif Lindholm, Peter Maydell, Marcin Juszkiewicz
The world outside moves to newer and newer cpu cores. Let move SBSA
Reference Platform to something newer as well.
Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
hw/arm/sbsa-ref.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index 0b93558dde..a1562f944a 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -852,7 +852,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data)
mc->init = sbsa_ref_init;
mc->desc = "QEMU 'SBSA Reference' ARM Virtual Machine";
- mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a57");
+ mc->default_cpu_type = ARM_CPU_TYPE_NAME("neoverse-n1");
mc->max_cpus = 512;
mc->pci_allow_0_address = true;
mc->minimum_page_bits = 12;
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1
2023-05-06 18:34 [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1 Marcin Juszkiewicz
@ 2023-05-12 14:50 ` Peter Maydell
2023-05-12 16:02 ` Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2023-05-12 14:50 UTC (permalink / raw)
To: Marcin Juszkiewicz; +Cc: qemu-devel, qemu-arm, Leif Lindholm
On Sat, 6 May 2023 at 19:34, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> The world outside moves to newer and newer cpu cores. Let move SBSA
> Reference Platform to something newer as well.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
> hw/arm/sbsa-ref.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 0b93558dde..a1562f944a 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -852,7 +852,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data)
>
> mc->init = sbsa_ref_init;
> mc->desc = "QEMU 'SBSA Reference' ARM Virtual Machine";
> - mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a57");
> + mc->default_cpu_type = ARM_CPU_TYPE_NAME("neoverse-n1");
> mc->max_cpus = 512;
> mc->pci_allow_0_address = true;
> mc->minimum_page_bits = 12;
Seems reasonable; Leif, any objection?
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1
2023-05-12 14:50 ` Peter Maydell
@ 2023-05-12 16:02 ` Leif Lindholm
2023-05-12 16:11 ` Marcin Juszkiewicz
2023-05-15 15:28 ` Peter Maydell
0 siblings, 2 replies; 5+ messages in thread
From: Leif Lindholm @ 2023-05-12 16:02 UTC (permalink / raw)
To: Peter Maydell, Marcin Juszkiewicz; +Cc: qemu-devel, qemu-arm
On 2023-05-12 15:50, Peter Maydell wrote:
> On Sat, 6 May 2023 at 19:34, Marcin Juszkiewicz
> <marcin.juszkiewicz@linaro.org> wrote:
>>
>> The world outside moves to newer and newer cpu cores. Let move SBSA
>> Reference Platform to something newer as well.
>>
>> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>> ---
>> hw/arm/sbsa-ref.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
>> index 0b93558dde..a1562f944a 100644
>> --- a/hw/arm/sbsa-ref.c
>> +++ b/hw/arm/sbsa-ref.c
>> @@ -852,7 +852,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data)
>>
>> mc->init = sbsa_ref_init;
>> mc->desc = "QEMU 'SBSA Reference' ARM Virtual Machine";
>> - mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a57");
>> + mc->default_cpu_type = ARM_CPU_TYPE_NAME("neoverse-n1");
>> mc->max_cpus = 512;
>> mc->pci_allow_0_address = true;
>> mc->minimum_page_bits = 12;
>
> Seems reasonable; Leif, any objection?
None.
Longer-term, I still want to move to "max" as the default, but that is
likely to require some invasive changes to TF-A, and this is already a
huge improvement. So:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Thanks!
/
Leif
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1
2023-05-12 16:02 ` Leif Lindholm
@ 2023-05-12 16:11 ` Marcin Juszkiewicz
2023-05-15 15:28 ` Peter Maydell
1 sibling, 0 replies; 5+ messages in thread
From: Marcin Juszkiewicz @ 2023-05-12 16:11 UTC (permalink / raw)
To: Leif Lindholm, Peter Maydell; +Cc: qemu-devel, qemu-arm
W dniu 12.05.2023 o 18:02, Leif Lindholm pisze:
> Longer-term, I still want to move to "max" as the default, but that is
> likely to require some invasive changes to TF-A, and this is already a
> huge improvement.
Firmware was main reason why I not moved to "max". It is easier to keep
system running when it models already existing core.
For me "max" stopped booting when FEAT_FGT landed in QEMU. Took over 3
months to enable it in TF-A.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1
2023-05-12 16:02 ` Leif Lindholm
2023-05-12 16:11 ` Marcin Juszkiewicz
@ 2023-05-15 15:28 ` Peter Maydell
1 sibling, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2023-05-15 15:28 UTC (permalink / raw)
To: Leif Lindholm; +Cc: Marcin Juszkiewicz, qemu-devel, qemu-arm
On Fri, 12 May 2023 at 17:02, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On 2023-05-12 15:50, Peter Maydell wrote:
> > On Sat, 6 May 2023 at 19:34, Marcin Juszkiewicz
> > <marcin.juszkiewicz@linaro.org> wrote:
> >>
> >> The world outside moves to newer and newer cpu cores. Let move SBSA
> >> Reference Platform to something newer as well.
> >>
> >> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> >> ---
> >> hw/arm/sbsa-ref.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> >> index 0b93558dde..a1562f944a 100644
> >> --- a/hw/arm/sbsa-ref.c
> >> +++ b/hw/arm/sbsa-ref.c
> >> @@ -852,7 +852,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data)
> >>
> >> mc->init = sbsa_ref_init;
> >> mc->desc = "QEMU 'SBSA Reference' ARM Virtual Machine";
> >> - mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a57");
> >> + mc->default_cpu_type = ARM_CPU_TYPE_NAME("neoverse-n1");
> >> mc->max_cpus = 512;
> >> mc->pci_allow_0_address = true;
> >> mc->minimum_page_bits = 12;
> >
> > Seems reasonable; Leif, any objection?
>
> None.
>
> Longer-term, I still want to move to "max" as the default, but that is
> likely to require some invasive changes to TF-A, and this is already a
> huge improvement. So:
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Thanks; applied to target-arm.next.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-15 15:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-06 18:34 [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1 Marcin Juszkiewicz
2023-05-12 14:50 ` Peter Maydell
2023-05-12 16:02 ` Leif Lindholm
2023-05-12 16:11 ` Marcin Juszkiewicz
2023-05-15 15:28 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).