From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] target/hppa: Generate illegal instruction exception for 64-bit instructions
Date: Wed, 28 Sep 2022 14:05:28 -0700 [thread overview]
Message-ID: <b85b7fce-2f58-632f-d198-2b01eb069152@linaro.org> (raw)
In-Reply-To: <YzSXKYBpJ2XeO+1C@p100>
On 9/28/22 11:49, Helge Deller wrote:
> Qemu currently emulates a 32-bit CPU only, and crashes with this error
> when it faces a 64-bit load (e.g. "ldd 0(r26),r0") or a 64-bit store
> (e.g. "std r26,0(r26)") instruction in the guest:
>
> ERROR:../qemu/tcg/tcg-op.c:2822:tcg_canonicalize_memop: code should not be reached
>
> Add checks for 64-bit sizes and generate an illegal instruction
> exception if necessary.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> v2: Move checks to trans_ld() and trans_st() as suggested by Richard
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2022-09-28 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 18:49 [PATCH v2] target/hppa: Generate illegal instruction exception for 64-bit instructions Helge Deller
2022-09-28 21:05 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b85b7fce-2f58-632f-d198-2b01eb069152@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).