From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@fungible.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Alexander Graf" <agraf@csgraf.de>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Duncan Bayne" <duncan@bayne.id.au>
Subject: Re: [PATCH] target/arm/hvf: Include missing "cpregs.h"
Date: Wed, 25 May 2022 11:45:56 -0700 [thread overview]
Message-ID: <b864b8b9-e88f-788b-6011-abd2b750b949@linaro.org> (raw)
In-Reply-To: <20220525161926.34233-1-philmd@fungible.com>
On 5/25/22 09:19, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Fix when building HVF on macOS Aarch64:
>
> target/arm/hvf/hvf.c:586:15: error: unknown type name 'ARMCPRegInfo'; did you mean 'ARMCPUInfo'?
> const ARMCPRegInfo *ri;
> ^~~~~~~~~~~~
> ARMCPUInfo
> target/arm/cpu-qom.h:38:3: note: 'ARMCPUInfo' declared here
> } ARMCPUInfo;
> ^
> target/arm/hvf/hvf.c:589:14: error: implicit declaration of function 'get_arm_cp_reginfo' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> ri = get_arm_cp_reginfo(arm_cpu->cp_regs, key);
> ^
> target/arm/hvf/hvf.c:589:12: warning: incompatible integer to pointer conversion assigning to 'const ARMCPUInfo *' (aka 'const struct ARMCPUInfo *') from 'int' [-Wint-conversion]
> ri = get_arm_cp_reginfo(arm_cpu->cp_regs, key);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> target/arm/hvf/hvf.c:591:26: error: no member named 'type' in 'struct ARMCPUInfo'
> assert(!(ri->type & ARM_CP_NO_RAW));
> ~~ ^
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'
> (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)
> ^
> target/arm/hvf/hvf.c:591:33: error: use of undeclared identifier 'ARM_CP_NO_RAW'
> assert(!(ri->type & ARM_CP_NO_RAW));
> ^
> 1 warning and 4 errors generated.
>
> Fixes: cf7c6d1004 ("target/arm: Split out cpregs.h")
> Reported-by: Duncan Bayne <duncan@bayne.id.au>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1029
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Oops, sorry about that.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-05-25 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 16:19 [PATCH] target/arm/hvf: Include missing "cpregs.h" Philippe Mathieu-Daudé
2022-05-25 18:45 ` Richard Henderson [this message]
2022-05-27 3:31 ` Zenghui Yu via
2022-05-30 9:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b864b8b9-e88f-788b-6011-abd2b750b949@linaro.org \
--to=richard.henderson@linaro.org \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=duncan@bayne.id.au \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@fungible.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).