From: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com,
mjt@tls.msk.ru, vsementsov@yandex-team.ru,
Eric Blake <eblake@redhat.com>,
"Denis V. Lunev" <den@virtuozzo.com>
Subject: Re: [PATCH 0/6] qemu-img: rebase: add compression support
Date: Wed, 16 Aug 2023 12:22:46 +0300 [thread overview]
Message-ID: <b865d41d-97df-4d5c-9e52-4fb2415d0af9@virtuozzo.com> (raw)
In-Reply-To: <962e464a-cb94-d1a0-5a74-52de34d25557@virtuozzo.com>
On 7/31/23 17:43, Andrey Drobyshev wrote:
> On 7/24/23 16:11, Andrey Drobyshev wrote:
>> On 6/30/23 13:54, Denis V. Lunev wrote:
>>> On 6/1/23 21:28, Andrey Drobyshev wrote:
>>>> This series is adding [-c | --compress] option to "qemu-img rebase"
>>>> command, which might prove useful for saving some disk space when, for
>>>> instance, manipulating chains of backup images. Along the way I had to
>>>> make a couple of minor improvements.
>>>>
>>>> The first 2 patches are a bug fix + corresponding test case.
>>>> Patch 3 merely fixes wrong args used in allocation.
>>>> Patch 4 makes write requests during rebase operation
>>>> cluster_size-aligned,
>>>> which seems to be beneficial for both non-compressed and compressed mode.
>>>> The last 2 patches are the actual feature implementation + tests.
>>>>
>>>> Andrey Drobyshev (6):
>>>> qemu-img: rebase: stop when reaching EOF of old backing file
>>>> qemu-iotests: 024: add rebasing test case for overlay_size >
>>>> backing_size
>>>> qemu-img: rebase: use backing files' BlockBackend for buffer alignment
>>>> qemu-img: rebase: avoid unnecessary COW operations
>>>> qemu-img: add compression option to rebase subcommand
>>>> iotests: add test 314 for "qemu-img rebase" with compression
>>>>
>>>> docs/tools/qemu-img.rst | 6 +-
>>>> qemu-img-cmds.hx | 4 +-
>>>> qemu-img.c | 106 ++++++++++++++++++------
>>>> tests/qemu-iotests/024 | 57 +++++++++++++
>>>> tests/qemu-iotests/024.out | 30 +++++++
>>>> tests/qemu-iotests/314 | 165 +++++++++++++++++++++++++++++++++++++
>>>> tests/qemu-iotests/314.out | 75 +++++++++++++++++
>>>> 7 files changed, 415 insertions(+), 28 deletions(-)
>>>> create mode 100755 tests/qemu-iotests/314
>>>> create mode 100644 tests/qemu-iotests/314.out
>>>>
>>> ping
>>
>> Friendly ping after 7 weeks
>
> Yet another ping
One more ping after 12 weeks of silence
next prev parent reply other threads:[~2023-08-16 9:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 19:28 [PATCH 0/6] qemu-img: rebase: add compression support Andrey Drobyshev via
2023-06-01 19:28 ` [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file Andrey Drobyshev via
2023-06-01 21:18 ` Michael Tokarev
2023-06-02 10:47 ` Andrey Drobyshev
2023-06-21 18:23 ` Denis V. Lunev
2023-08-25 14:29 ` Hanna Czenczek
2023-10-26 6:32 ` Michael Tokarev
2023-10-26 8:16 ` Andrey Drobyshev
2023-06-01 19:28 ` [PATCH 2/6] qemu-iotests: 024: add rebasing test case for overlay_size > backing_size Andrey Drobyshev via
2023-06-21 18:23 ` Denis V. Lunev
2023-08-25 14:29 ` Hanna Czenczek
2023-06-01 19:28 ` [PATCH 3/6] qemu-img: rebase: use backing files' BlockBackend for buffer alignment Andrey Drobyshev via
2023-06-21 18:16 ` Denis V. Lunev
2023-08-25 14:29 ` Hanna Czenczek
2023-08-29 7:06 ` Andrey Drobyshev
2023-08-29 8:44 ` Hanna Czenczek
2023-06-01 19:28 ` [PATCH 4/6] qemu-img: rebase: avoid unnecessary COW operations Andrey Drobyshev via
2023-06-21 18:53 ` Denis V. Lunev
2023-08-25 15:00 ` Hanna Czenczek
2023-08-29 13:27 ` Andrey Drobyshev
2023-06-01 19:28 ` [PATCH 5/6] qemu-img: add compression option to rebase subcommand Andrey Drobyshev via
2023-06-21 18:22 ` Denis V. Lunev
2023-08-25 15:14 ` Hanna Czenczek
2023-06-01 19:28 ` [PATCH 6/6] iotests: add test 314 for "qemu-img rebase" with compression Andrey Drobyshev via
2023-06-21 19:16 ` Denis V. Lunev
2023-08-25 15:17 ` Hanna Czenczek
2023-06-30 10:54 ` [PATCH 0/6] qemu-img: rebase: add compression support Denis V. Lunev
2023-07-07 11:33 ` Andrey Drobyshev
2023-07-24 13:11 ` Andrey Drobyshev
2023-07-31 14:43 ` Andrey Drobyshev
2023-08-16 9:22 ` Andrey Drobyshev [this message]
2023-08-22 17:35 ` Andrey Drobyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b865d41d-97df-4d5c-9e52-4fb2415d0af9@virtuozzo.com \
--to=andrey.drobyshev@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).