From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, laurent@vivier.eu,
fthain@telegraphics.com.au
Subject: Re: [PATCH 01/22] adb: coding style update to fix checkpatch errors
Date: Sun, 14 Jun 2020 18:49:50 +0200 [thread overview]
Message-ID: <b86bc62c-1cbe-96cf-8e4f-d282fe2a6d1e@amsat.org> (raw)
In-Reply-To: <20200614142840.10245-2-mark.cave-ayland@ilande.co.uk>
On 6/14/20 4:28 PM, Mark Cave-Ayland wrote:
> This will help ensure that style guidelines are being maintained during
> subsequent changes.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/input/adb.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/input/adb.c b/hw/input/adb.c
> index b1ac4a3852..bf1bc30d19 100644
> --- a/hw/input/adb.c
> +++ b/hw/input/adb.c
> @@ -44,14 +44,14 @@ int adb_request(ADBBusState *s, uint8_t *obuf, const uint8_t *buf, int len)
>
> cmd = buf[0] & 0xf;
> if (cmd == ADB_BUSRESET) {
> - for(i = 0; i < s->nb_devices; i++) {
> + for (i = 0; i < s->nb_devices; i++) {
> d = s->devices[i];
> adb_device_reset(d);
> }
> return 0;
> }
> devaddr = buf[0] >> 4;
> - for(i = 0; i < s->nb_devices; i++) {
> + for (i = 0; i < s->nb_devices; i++) {
> d = s->devices[i];
> if (d->devaddr == devaddr) {
> ADBDeviceClass *adc = ADB_DEVICE_GET_CLASS(d);
> @@ -69,9 +69,10 @@ int adb_poll(ADBBusState *s, uint8_t *obuf, uint16_t poll_mask)
> uint8_t buf[1];
>
> olen = 0;
> - for(i = 0; i < s->nb_devices; i++) {
> - if (s->poll_index >= s->nb_devices)
> + for (i = 0; i < s->nb_devices; i++) {
> + if (s->poll_index >= s->nb_devices) {
> s->poll_index = 0;
> + }
> d = s->devices[s->poll_index];
> if ((1 << d->devaddr) & poll_mask) {
> buf[0] = ADB_READREG | (d->devaddr << 4);
>
next prev parent reply other threads:[~2020-06-14 16:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 14:28 [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 01/22] adb: coding style update to fix checkpatch errors Mark Cave-Ayland
2020-06-14 16:49 ` Philippe Mathieu-Daudé [this message]
2020-06-14 14:28 ` [PATCH 02/22] adb: fix adb-mouse read length and revert disable-reg3-direct-writes workaround Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 03/22] cuda: convert ADB autopoll timer from ns to ms Mark Cave-Ayland
2020-06-14 16:50 ` Philippe Mathieu-Daudé
2020-06-14 14:28 ` [PATCH 04/22] pmu: fix duplicate autopoll mask variable Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 05/22] pmu: honour autopoll_rate_ms when rearming the ADB autopoll timer Mark Cave-Ayland
2020-06-14 16:50 ` Philippe Mathieu-Daudé
2020-06-14 14:28 ` [PATCH 06/22] adb: introduce realize/unrealize and VMStateDescription for ADB bus Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 07/22] adb: create autopoll variables directly within ADBBusState Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 08/22] cuda: convert to use ADBBusState internal autopoll variables Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 09/22] pmu: " Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 10/22] mac_via: " Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 11/22] adb: introduce new ADBDeviceHasData method to ADBDeviceClass Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 12/22] adb: keep track of devices with pending data Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 13/22] adb: add status field for holding information about the last ADB request Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 14/22] adb: use adb_request() only for explicit requests Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 15/22] adb: add autopoll_blocked variable to block autopoll Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 16/22] cuda: add adb_autopoll_block() and adb_autopoll_unblock() functions Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 17/22] pmu: " Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 18/22] mac_via: move VIA1 portB write logic into mos6522_q800_via1_write() Mark Cave-Ayland
2020-06-14 17:03 ` Philippe Mathieu-Daudé
2020-06-14 14:28 ` [PATCH 19/22] mac_via: rework ADB state machine to be compatible with both MacOS and Linux Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 20/22] adb: only call autopoll callbacks when autopoll is not blocked Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 21/22] adb: use adb_device prefix for ADB device trace events Mark Cave-Ayland
2020-06-14 17:20 ` Philippe Mathieu-Daudé
2020-06-20 12:01 ` Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 22/22] adb: add ADB bus " Mark Cave-Ayland
2020-06-14 17:16 ` Philippe Mathieu-Daudé
2020-06-20 11:59 ` Mark Cave-Ayland
2020-06-16 10:24 ` [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine Finn Thain
2020-06-20 12:10 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b86bc62c-1cbe-96cf-8e4f-d282fe2a6d1e@amsat.org \
--to=f4bug@amsat.org \
--cc=fthain@telegraphics.com.au \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).