From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0727BC47082 for ; Sun, 6 Jun 2021 00:29:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BCD261415 for ; Sun, 6 Jun 2021 00:29:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BCD261415 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpgfG-00078a-38 for qemu-devel@archiver.kernel.org; Sat, 05 Jun 2021 20:29:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpgeP-0006RO-Pk for qemu-devel@nongnu.org; Sat, 05 Jun 2021 20:28:25 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:38442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpgeN-0000W0-00 for qemu-devel@nongnu.org; Sat, 05 Jun 2021 20:28:25 -0400 Received: by mail-pg1-x532.google.com with SMTP id 6so10944959pgk.5 for ; Sat, 05 Jun 2021 17:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=mmE8sMs83/0vm8GMO5yMPhyHYwK+srj02hoA1IPnEbQ=; b=jtOvcGAqMlr5St/BkKUhmhhFn9gnwvliHszh13XpRzZXH2jR1DayHHNsWiFk/Owlxn 5/DLSTkbRAY1o6FkUwkrwCrqOfV2QO3KUI8Z+NXkZ+7rcU54CaDTM6+dZj9I/TQIwgnx MvQBv4VmIk7iJZi03osdD7UYETaNf4gwBF98YVU2hHKPfC7HJ39z8mfbpeMhdogJ1nfl yae2KBWC0QdMk3xRV0Qg0lo9bW5hrSz1OYHGbQ5JHotCoge9D/vPzouqdiozNKULJmZ9 iVztu/9ctXZQ8oKya3s/IJe8MCqTYa2uHsOFRPAAHD1uhPDxxrtCf4tAl4OKaBxwDYPI GbfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mmE8sMs83/0vm8GMO5yMPhyHYwK+srj02hoA1IPnEbQ=; b=n83gLC0l4sgRlNUvhnPuhUP4E3ibFPI6BJTYYUeWRGmOUKfL17/BFkR8NeObGF1RhM sDQozE62GWe9suurkK+yUlqRu4zeroLu4ma4PsUIzLsze4LboBPXrhp6g0OPnqLkhZEf VZsZ0a+ej2MsOM3GrHuq0lUNMcffFE3opo/cZeDaQ65SPbwgNPIErSzqGtJx1p6zh4mm 8YcnJYsie1wI6AEeqgculsVliEzk46nvehizRPk0f9vDdXAlMD2bRmlgZAZEsjqoT78e TkyIg/hFE4TsB6SHHwE1UdHE3oI8EOw6M7XiHNcM5jbxMRtZKNMK1/wY7LxOQdQ6n5Bt xQFg== X-Gm-Message-State: AOAM531azjbQJPHnsWATLN/MBtdAs9LA+Cb1PhNcOpcC0qOz9M3x2asy vxXze1dBoeghkF7AGbSfgJCOspN2wt2L3w== X-Google-Smtp-Source: ABdhPJzSk/UpHKvFl7Wd3M5BeQ3oG1lbvx3htkDnvAnVwyKUbSwxeZaMxaKVrNboPijMHRX92YMwEw== X-Received: by 2002:a63:8f46:: with SMTP id r6mr11888214pgn.182.1622939301282; Sat, 05 Jun 2021 17:28:21 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id j16sm5552669pgh.69.2021.06.05.17.28.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Jun 2021 17:28:20 -0700 (PDT) Subject: Re: [PATCH 3/8] Fix initialization of the hwrpb.hwrpb.cpuid field. To: Jason Thorpe , qemu-devel@nongnu.org References: <20210603035317.6814-1-thorpej@me.com> <20210603035317.6814-4-thorpej@me.com> From: Richard Henderson Message-ID: Date: Sat, 5 Jun 2021 17:28:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210603035317.6814-4-thorpej@me.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.59, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/2/21 8:53 PM, Jason Thorpe wrote: > Initialize the hwrpb.hwrpb.cpuid field with the primary CPU ID, not > the processor type, as per the architecture specification. Some > operating systems check and assert this. > > Improve a couple of comments. > > Signed-off-by: Jason Thorpe > --- > init.c | 29 ++++++++++++++++++++++------- > 1 file changed, 22 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson > @@ -257,8 +272,8 @@ init_i8259 (void) > outb(0x04, PORT_PIC1_DATA); /* ICW3: slave control INTC2 */ > outb(0x01, PORT_PIC1_DATA); /* ICW4 */ > > - /* Initialize level triggers. The CY82C693UB that's on real alpha > - hardware doesn't have this; this is a PIIX extension. However, > + /* Initialize level triggers. The CY82C693UB that's on some real alpha > + systems controls these differently; we assume a PIIX here. However, > QEMU doesn't implement regular level triggers. */ > outb(0xff, PORT_PIC2_ELCR); > outb(0xff, PORT_PIC1_ELCR); I'll split this out to a separate patch. r~