From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5A8C433DB for ; Tue, 9 Mar 2021 14:12:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49D0865228 for ; Tue, 9 Mar 2021 14:12:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49D0865228 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJd6T-0005Tn-6a for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 09:12:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJd5R-00048I-DH for qemu-devel@nongnu.org; Tue, 09 Mar 2021 09:11:49 -0500 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:40269) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJd5N-0007WE-SC for qemu-devel@nongnu.org; Tue, 09 Mar 2021 09:11:49 -0500 Received: by mail-ot1-x330.google.com with SMTP id b8so12898110oti.7 for ; Tue, 09 Mar 2021 06:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5d6h/oI05GGkXzLRzzB+ytQLWVabxb3ZgNJ5byndeWY=; b=Ksa8GLJud2pA4O7d1v5uF/NlR0JQU0Z5rJ6KWtpJcNf0Wts7CudaoUyjbox3TyUie5 u9cIn5m+GeK0sKvhJJQ0fwJwsJX55HKFCiN/EgEjdNv4MpLNQX59DX2VDxTh1DW+EJS/ 3o4sBaEe5U/O9+JsGHkkOQeSPY/maKr61g9zHmH6T0ITr1I5WdUJ9LivlnonEw15y6a5 yOoFIL33mEXc9iylCovoMq+9NAlNLjtJqu+AXK/tiYXJbfwuZdqkqHpSl64oYIIAp8YO GiIdfWgu0g5qP1BI5Xi+Gjg2dctziMO3+ymiLaK190nwexXKIckIQGZqenBWB04QASY0 vV/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5d6h/oI05GGkXzLRzzB+ytQLWVabxb3ZgNJ5byndeWY=; b=Nc/CTfMatbJGjKyTQSpUxgQXtBdzAGQks/uqmCgUfup/hgUNV5kFm+O+GN60Ax8C8K 3CC0AyhYcREe77fSLNhs1GvNqYmWYXae4UyEpcAPJ4oITmcfjS5THf+kKNRVbsmSp36X 52L0n6aMmwF/dv/EgjsFcwBywnidYUadAPJA6wBxdsY0KrEZvbKOIgoUx7gAUPNQu+9F zcoaVFbkKRMFU323H8EOCvQEnNmoqth36Gu8aupsyWKCtsoA3GD9zy6osZ0SmyeCCzAt Q/kyjl3WMnbsh+5X5uwGyJcXejFRrhLvIWotOE+pr1AGpFoPeqq7x1JqTQrUAdZFCouX NJhg== X-Gm-Message-State: AOAM530zol0XwESF/aicbW/f0BkX2M52zLzH/HttRHyn5C/+/27vKWGv kLa2m3t0ZYhfIE3A7C6EX5X15g== X-Google-Smtp-Source: ABdhPJy72fkbiuw81RhmCfcG90mseFPomxXWmLKFJG9OwsCacar53MSPgNPG7GjVL6vbo1CmVjpY/Q== X-Received: by 2002:a9d:5c0c:: with SMTP id o12mr22561066otk.367.1615299103757; Tue, 09 Mar 2021 06:11:43 -0800 (PST) Received: from [192.168.3.43] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id j19sm3111437oie.6.2021.03.09.06.11.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 06:11:43 -0800 (PST) Subject: Re: [PATCH] target/mips: Use gen_load_gpr[_hi]() when possible To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210308131604.460693-1-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Tue, 9 Mar 2021 06:11:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210308131604.460693-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/8/21 5:16 AM, Philippe Mathieu-Daudé wrote: > Use gen_load_gpr[_hi]() instead of open coding it. > > Patch generated using the following spatch script: > > @gen_load_gpr@ > identifier reg_idx; > expression tcg_reg; > @@ > -if (reg_idx == 0) { > - tcg_gen_movi_tl(tcg_reg, 0); > -} else { > - tcg_gen_mov_tl(tcg_reg, cpu_gpr[reg_idx]); > -} > +gen_load_gpr(tcg_reg, reg_idx); > > @gen_load_gpr_hi@ > identifier reg_idx; > expression tcg_reg; > @@ > -if (reg_idx == 0) { > - tcg_gen_movi_i64(tcg_reg, 0); > -} else { > - tcg_gen_mov_i64(tcg_reg, cpu_gpr_hi[reg_idx]); > -} > +gen_load_gpr_hi(tcg_reg, reg_idx); > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Richard Henderson r~