From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4/6] tests/qtest/virtio-iommu-test: Don't pass uninitialized data into qtest_memwrite
Date: Mon, 9 Dec 2024 22:06:06 +0100 [thread overview]
Message-ID: <b8a4ed66-22b5-488e-bc63-e8d960943685@linaro.org> (raw)
In-Reply-To: <20241209204427.17763-5-farosas@suse.de>
On 9/12/24 21:44, Fabiano Rosas wrote:
> Valgrind complains about:
>
> Use of uninitialised value of size 8
> &
> Conditional jump or move depends on uninitialised value(s)
>
> both at:
> at 0x5265931: _itoa_word (_itoa.c:180)
> by 0x527EEC7: __vfprintf_internal (vfprintf-internal.c:1687)
> by 0x528C8B0: __vsprintf_internal (iovsprintf.c:96)
> by 0x526B920: sprintf (sprintf.c:30)
> by 0x1296C7: qtest_memwrite (libqtest.c:1273)
> by 0x193C04: send_map (virtio-iommu-test.c:125)
> by 0x194392: test_attach_detach (virtio-iommu-test.c:214)
> by 0x17BDE7: run_one_test (qos-test.c:181)
> by 0x4B0699D: test_case_run (gtestutils.c:2900)
> by 0x4B0699D: g_test_run_suite_internal (gtestutils.c:2988)
> by 0x4B068B2: g_test_run_suite_internal (gtestutils.c:3005)
> by 0x4B068B2: g_test_run_suite_internal (gtestutils.c:3005)
> by 0x4B068B2: g_test_run_suite_internal (gtestutils.c:3005)
> Uninitialised value was created by a stack allocation
> at 0x193AFD: send_map (virtio-iommu-test.c:103)
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/qtest/virtio-iommu-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-12-09 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 20:44 [PATCH 0/6] qtest: Fix some memory issues Fabiano Rosas
2024-12-09 20:44 ` [PATCH 1/6] tests/qtest/migration: Do proper cleanup in the dirty_limit test Fabiano Rosas
2024-12-09 21:11 ` Peter Xu
2024-12-09 20:44 ` [PATCH 2/6] tests/qtest/migration: Initialize buffer in probe_o_direct_support Fabiano Rosas
2024-12-09 21:02 ` Philippe Mathieu-Daudé
2024-12-09 21:14 ` Peter Xu
2024-12-09 20:44 ` [PATCH 3/6] tests/qtest/bios-tables-test: Free tables at dump_aml_files Fabiano Rosas
2024-12-09 21:04 ` Philippe Mathieu-Daudé
2024-12-09 20:44 ` [PATCH 4/6] tests/qtest/virtio-iommu-test: Don't pass uninitialized data into qtest_memwrite Fabiano Rosas
2024-12-09 21:06 ` Philippe Mathieu-Daudé [this message]
2024-12-09 20:44 ` [PATCH 5/6] tests/qtest/qos-test: Plug a couple of leaks Fabiano Rosas
2024-12-09 20:44 ` [PATCH 6/6] tests/qtest/test-x86-cpuid-compat: Free allocated memory Fabiano Rosas
2024-12-17 18:13 ` [PATCH 0/6] qtest: Fix some memory issues Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8a4ed66-22b5-488e-bc63-e8d960943685@linaro.org \
--to=philmd@linaro.org \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).