* [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers
@ 2018-12-19 9:12 Markus Armbruster
2018-12-19 17:01 ` Roman Bolshakov
2018-12-19 22:12 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Markus Armbruster @ 2018-12-19 9:12 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
Avoids pointless recompilation. Missed in commit 112ed241f5d.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
Untested; I don't have access to a Mac.
ui/cocoa.m | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index ecf12bfc2e..43e751693c 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -32,7 +32,8 @@
#include "ui/input.h"
#include "sysemu/sysemu.h"
#include "qapi/error.h"
-#include "qapi/qapi-commands.h"
+#include "qapi/qapi-commands-block-core.h"
+#include "qapi/qapi-commands-misc.h"
#include "sysemu/blockdev.h"
#include "qemu-version.h"
#include <Carbon/Carbon.h>
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers
2018-12-19 9:12 [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers Markus Armbruster
@ 2018-12-19 17:01 ` Roman Bolshakov
2018-12-19 18:14 ` Markus Armbruster
2018-12-19 22:12 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Roman Bolshakov @ 2018-12-19 17:01 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, peter.maydell
On Wed, Dec 19, 2018 at 10:12:48AM +0100, Markus Armbruster wrote:
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Untested; I don't have access to a Mac.
>
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index ecf12bfc2e..43e751693c 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -32,7 +32,8 @@
> #include "ui/input.h"
> #include "sysemu/sysemu.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands.h"
> +#include "qapi/qapi-commands-block-core.h"
> +#include "qapi/qapi-commands-misc.h"
> #include "sysemu/blockdev.h"
> #include "qemu-version.h"
> #include <Carbon/Carbon.h>
> --
> 2.17.2
>
>
Hi Markus,
You should change change qapi/qapi-commands-block-core.h to
qapi/qapi-commands-block.h to avoid:
ui/cocoa.m:1225:5: warning: implicit declaration of function 'qmp_eject' is invalid in C99 [-Wimplicit-function-declaration]
qmp_eject(true, [drive cStringUsingEncoding: NSASCIIStringEncoding],
^
ui/cocoa.m:1225:5: warning: this function declaration is not a prototype [-Wstrict-prototypes]
Thanks,
Roman
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers
2018-12-19 17:01 ` Roman Bolshakov
@ 2018-12-19 18:14 ` Markus Armbruster
0 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2018-12-19 18:14 UTC (permalink / raw)
To: Roman Bolshakov; +Cc: peter.maydell, qemu-devel
Roman Bolshakov <r.bolshakov@yadro.com> writes:
> On Wed, Dec 19, 2018 at 10:12:48AM +0100, Markus Armbruster wrote:
>> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> Untested; I don't have access to a Mac.
>>
>> ui/cocoa.m | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/ui/cocoa.m b/ui/cocoa.m
>> index ecf12bfc2e..43e751693c 100644
>> --- a/ui/cocoa.m
>> +++ b/ui/cocoa.m
>> @@ -32,7 +32,8 @@
>> #include "ui/input.h"
>> #include "sysemu/sysemu.h"
>> #include "qapi/error.h"
>> -#include "qapi/qapi-commands.h"
>> +#include "qapi/qapi-commands-block-core.h"
>> +#include "qapi/qapi-commands-misc.h"
>> #include "sysemu/blockdev.h"
>> #include "qemu-version.h"
>> #include <Carbon/Carbon.h>
>> --
>> 2.17.2
>>
>>
>
> Hi Markus,
>
> You should change change qapi/qapi-commands-block-core.h to
> qapi/qapi-commands-block.h to avoid:
>
> ui/cocoa.m:1225:5: warning: implicit declaration of function 'qmp_eject' is invalid in C99 [-Wimplicit-function-declaration]
> qmp_eject(true, [drive cStringUsingEncoding: NSASCIIStringEncoding],
> ^
> ui/cocoa.m:1225:5: warning: this function declaration is not a prototype [-Wstrict-prototypes]
>
> Thanks,
> Roman
Will do, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers
2018-12-19 9:12 [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers Markus Armbruster
2018-12-19 17:01 ` Roman Bolshakov
@ 2018-12-19 22:12 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-12-19 22:12 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: peter.maydell
On 12/19/18 10:12 AM, Markus Armbruster wrote:
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Untested; I don't have access to a Mac.
You kinda do, open a GitHub account and enable Travis-CI (free for
public projects), then pushing a branch to your GitHub will trigger a
Travis build:
https://travis-ci.org/philmd/qemu/jobs/470146270#L3047
>
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index ecf12bfc2e..43e751693c 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -32,7 +32,8 @@
> #include "ui/input.h"
> #include "sysemu/sysemu.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands.h"
> +#include "qapi/qapi-commands-block-core.h"
> +#include "qapi/qapi-commands-misc.h"
> #include "sysemu/blockdev.h"
> #include "qemu-version.h"
> #include <Carbon/Carbon.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-19 22:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-19 9:12 [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers Markus Armbruster
2018-12-19 17:01 ` Roman Bolshakov
2018-12-19 18:14 ` Markus Armbruster
2018-12-19 22:12 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).