From: Eric Farman <farman@linux.ibm.com>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
tomitamoeko@gmail.com, corvin.koehne@gmail.com,
Kirti Wankhede <kwankhede@nvidia.com>,
Joao Martins <joao.m.martins@oracle.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Eric Auger <eric.auger@redhat.com>
Subject: Re: [PATCH v4] vfio: Add property documentation
Date: Mon, 24 Feb 2025 12:07:31 -0500 [thread overview]
Message-ID: <b8b54a18d9975633bd536341e419290c48a02794.camel@linux.ibm.com> (raw)
In-Reply-To: <20250217173455.449983-1-clg@redhat.com>
On Mon, 2025-02-17 at 18:34 +0100, Cédric Le Goater wrote:
> Investigate the git history to uncover when and why the VFIO
> properties were introduced and update the models. This is mostly
> targeting vfio-pci device, since vfio-platform, vfio-ap and vfio-ccw
> devices are simpler.
>
> Sort the properties based on the QEMU version in which they were
> introduced.
>
> Cc: Tony Krowiak <akrowiak@linux.ibm.com>
> Cc: Eric Farman <farman@linux.ibm.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>
> Should we introduce documentation for properties like the kernel has
> in Documentation/ABI/*/sysfs-* ?
>
> Changes in v4:
>
> - Latest improvements from Alex
>
> Changes in v3:
>
> - Re-organized the vfio-pci properties based on the QEMU version in
> which they were introduced
> - Added property labels
> - Improved description as suggested by Alex, Tomita and Corvin
>
> Changes in v2:
>
> - Fixed version numbers
> - Fixed #ifdef in vfio/ccw.c
> - Addressed vfio-pci-nohotplug
> - Organize the vfio-pci properties in topics
>
> hw/vfio/ap.c | 9 ++++
> hw/vfio/ccw.c | 15 ++++++
> hw/vfio/pci.c | 125 +++++++++++++++++++++++++++++++++++++++++++++
> hw/vfio/platform.c | 24 +++++++++
> 4 files changed, 173 insertions(+)
Reviewed-by: Eric Farman <farman@linux.ibm.com> # vfio-ccw
next prev parent reply other threads:[~2025-02-24 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 17:34 [PATCH v4] vfio: Add property documentation Cédric Le Goater
2025-02-17 17:54 ` Eric Auger
2025-02-18 15:19 ` Alex Williamson
2025-02-18 15:33 ` Cédric Le Goater
2025-02-24 17:07 ` Eric Farman [this message]
2025-02-25 10:48 ` Anthony Krowiak
2025-02-25 12:38 ` Kirti Wankhede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b54a18d9975633bd536341e419290c48a02794.camel@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=corvin.koehne@gmail.com \
--cc=eric.auger@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=kwankhede@nvidia.com \
--cc=qemu-devel@nongnu.org \
--cc=tomitamoeko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).