From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9EC1C433DB for ; Fri, 12 Mar 2021 09:11:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BE1764F12 for ; Fri, 12 Mar 2021 09:11:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE1764F12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKdYj-0005EW-9H for qemu-devel@archiver.kernel.org; Fri, 12 Mar 2021 03:54:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKdXH-0004NF-OK; Fri, 12 Mar 2021 03:52:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:35962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKdXA-0003Ju-68; Fri, 12 Mar 2021 03:52:42 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 590F3AF47; Fri, 12 Mar 2021 08:52:34 +0000 (UTC) Subject: Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command To: Andrew Jones , Thomas Huth References: <20210311231202.1536040-1-philmd@redhat.com> <20210311231202.1536040-2-philmd@redhat.com> <651baead-dcc3-c0ef-f5dd-cda36c8d6599@redhat.com> <20210312084816.pnenjcbdjzwu3z54@kamzik.brq.redhat.com> From: Claudio Fontana Message-ID: Date: Fri, 12 Mar 2021 09:52:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210312084816.pnenjcbdjzwu3z54@kamzik.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , "Michael S. Tsirkin" , libvir-list@redhat.com, Richard Henderson , QEMU , Markus Armbruster , "open list:ARM" , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini , Igor Mammedov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/12/21 9:48 AM, Andrew Jones wrote: > On Fri, Mar 12, 2021 at 09:11:45AM +0100, Thomas Huth wrote: >> On 12/03/2021 08.42, Marc-André Lureau wrote: >>> >>> >>> On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé >>> > wrote: >>> >> [...] >>> +## >>> +# @AcceleratorInfo: >>> +# >>> +# Accelerator information. >>> +# >>> +# @name: The accelerator name. >>> +# >>> +# Since: 6.0 >>> +## >>> +{ 'union': 'AcceleratorInfo', >>> +  'base': {'name': 'Accelerator'}, >>> +  'discriminator': 'name', >>> +  'data': { } } >>> >>> + >>> >>> >>> Making room for future details, why not. >> >> I think we definitely need the additional data section here: For KVM on >> POWER, it would be good to know whether it's KVM-HV or KVM-PR, for KVM on >> MIPS it would be good to know whether it's KVM_VM_MIPS_VZ or KVM_VM_MIPS_TE, >> for KVM on x86 whether it's the AMD flavor or Intel, ... > > Could also pre-expand all of these and list them individually. Let us consider simplicity for the reader, and which use cases we expect for this. > >> >>> +## >>> +# @query-accels: >>> +# >>> +# Get a list of AcceleratorInfo for all built-in accelerators. >>> +# >>> +# Returns: a list of @AcceleratorInfo describing each accelerator. >>> +# >>> +# Since: 6.0 >>> +# >>> +# Example: >>> +# >>> +# -> { "execute": "query-accels" } >>> +# <- { "return": [ >>> +#        { >>> +#            "type": "qtest" >>> +#        }, >>> +#        { >>> +#            "type": "kvm" >>> +#        } >>> +#    ] } >>> +# >>> +## >>> +{ 'command': 'query-accels', >>> +  'returns': ['AcceleratorInfo'] } >>> >>> >>> That's nice, but how do you know which accels are actually enabled? >> >> I guess we need two commands in the end, one for querying which accelerators >> are available, and one for querying the data from the currently active >> accelerator...? >> > > If we listed each accelerator individually, then we could use booleans > for them, where only the active one would be true. If we can't come up > with another need for the accelerator-specific info now, then I'd leave > it to be added at a later time when it is needed. > > Thanks, > drew >