From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5ly-0002Fm-N9 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:18:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn5lu-0007fd-MB for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:18:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5lu-0007f8-FG for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:18:46 -0400 References: <147455590865.8519.11191009507297313736.stgit@brijesh-build-machine> <147455594859.8519.8825725423514687933.stgit@brijesh-build-machine> From: Paolo Bonzini Message-ID: Date: Thu, 22 Sep 2016 17:18:40 +0200 MIME-Version: 1.0 In-Reply-To: <147455594859.8519.8825725423514687933.stgit@brijesh-build-machine> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 04/16] monitor: use debug version of memory access apis List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh , ehabkost@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mst@redhat.com, p.fedin@samsung.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, rth@twiddle.net On 22/09/2016 16:52, Brijesh Singh wrote: > diff --git a/target-i386/monitor.c b/target-i386/monitor.c > index fccfe40..47d3c2d 100644 > --- a/target-i386/monitor.c > +++ b/target-i386/monitor.c > @@ -130,12 +130,12 @@ static void tlb_info_64(Monitor *mon, CPUArchState *env) > > pml4_addr = env->cr[3] & 0x3fffffffff000ULL; > for (l1 = 0; l1 < 512; l1++) { > - cpu_physical_memory_read(pml4_addr + l1 * 8, &pml4e, 8); > + cpu_physical_memory_read_debug(pml4_addr + l1 * 8, &pml4e, 8); > pml4e = le64_to_cpu(pml4e); > if (pml4e & PG_PRESENT_MASK) { > pdp_addr = pml4e & 0x3fffffffff000ULL; > for (l2 = 0; l2 < 512; l2++) { > - cpu_physical_memory_read(pdp_addr + l2 * 8, &pdpe, 8); > + cpu_physical_memory_read_debug(pdp_addr + l2 * 8, &pdpe, 8); > pdpe = le64_to_cpu(pdpe); > if (pdpe & PG_PRESENT_MASK) { > if (pdpe & PG_PSE_MASK) { Please use ldq_phys_debug instead here and in mem_info_64. Paolo