From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Michael Rolnik" <mrolnik@gmail.com>
Cc: Sarah Harris <S.E.Harris@kent.ac.uk>,
Joaquin de Andres <me@xcancerberox.com.ar>,
Richard Henderson <richard.henderson@linaro.org>,
Pavel Dovgalyuk <dovgaluk@ispras.ru>,
Igor Mammedov <imammedo@redhat.com>,
Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Subject: Re: [PATCH v2 3/8] hw/avr: Add some ATmega microcontrollers
Date: Sat, 21 Dec 2019 12:15:04 +0100 [thread overview]
Message-ID: <b8c186f8-9684-a636-d93e-027c218517c8@redhat.com> (raw)
In-Reply-To: <20191221010226.9230-4-f4bug@amsat.org>
On 12/21/19 2:02 AM, Philippe Mathieu-Daudé wrote:
> Add some microcontrollers from the megaAVR family (ATmega series):
>
> - middle range: ATmega168 and ATmega328
> - high range: ATmega1280 and ATmega2560
>
> For product comparison:
> https://www.microchip.com/wwwproducts/ProductCompare/ATmega168P/ATmega328P
> https://www.microchip.com/wwwproducts/ProductCompare/ATmega1280/ATmega2560
>
> Datasheets:
> http://ww1.microchip.com/downloads/en/DeviceDoc/ATmega48A-PA-88A-PA-168A-PA-328-P-DS-DS40002061A.pdf
> http://ww1.microchip.com/downloads/en/DeviceDoc/Atmel-2549-8-bit-AVR-Microcontroller-ATmega640-1280-1281-2560-2561_datasheet.pdf
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - Reword description adding more information (Aleksandar)
> - Use DEFINE_TYPES and memory_region_init_ram (Igor)
>
> Cc: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/avr/atmega.h | 48 +++++
> hw/avr/atmega.c | 460 +++++++++++++++++++++++++++++++++++++++++++
> hw/avr/Makefile.objs | 1 +
> 3 files changed, 509 insertions(+)
> create mode 100644 hw/avr/atmega.h
> create mode 100644 hw/avr/atmega.c
>
[...]
> diff --git a/hw/avr/Makefile.objs b/hw/avr/Makefile.objs
> index 626b7064b3..4b6b911820 100644
> --- a/hw/avr/Makefile.objs
> +++ b/hw/avr/Makefile.objs
> @@ -1 +1,2 @@
> obj-y += sample.o
> +obj-y += atmega.o
Should this have a proper Kconfig entry, and in next patch Arduino
selects it? Probably cleaner and in match with other archs.
next prev parent reply other threads:[~2019-12-21 11:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 1:02 [PATCH v2 0/8] hw/avr: Introduce the Arduino boards Philippe Mathieu-Daudé
2019-12-21 1:02 ` [PATCH v2 1/8] hw/char/avr: Reduce USART I/O size Philippe Mathieu-Daudé
2019-12-21 1:02 ` [PATCH v2 2/8] hw/timer/avr_timer16: Rename memory region debugging name Philippe Mathieu-Daudé
2019-12-21 1:02 ` [PATCH v2 3/8] hw/avr: Add some ATmega microcontrollers Philippe Mathieu-Daudé
2019-12-21 11:15 ` Philippe Mathieu-Daudé [this message]
2019-12-21 1:02 ` [PATCH v2 4/8] hw/avr: Add some Arduino boards Philippe Mathieu-Daudé
2019-12-21 1:02 ` [PATCH v2 5/8] tests/boot-serial-test: Test some Arduino boards (AVR based) Philippe Mathieu-Daudé
2019-12-21 1:02 ` [PATCH v2 6/8] tests/acceptance: Do not set the machine type manually Philippe Mathieu-Daudé
2019-12-21 1:02 ` [PATCH v2 7/8] tests/acceptance: Keep multilines comment consistent with other tests Philippe Mathieu-Daudé
2019-12-21 1:02 ` [PATCH v2 8/8] tests/acceptance: Test the Arduino MEGA2560 board Philippe Mathieu-Daudé
2019-12-21 1:05 ` [PATCH v2 0/8] hw/avr: Introduce the Arduino boards Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c186f8-9684-a636-d93e-027c218517c8@redhat.com \
--to=philmd@redhat.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.m.mail@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=me@xcancerberox.com.ar \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).