From: Thomas Huth <thuth@redhat.com>
To: Gan Qixin <ganqixin@huawei.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
zhang.zhanghailiang@huawei.com, laurent@vivier.eu,
armbru@redhat.com, qemu-arm <qemu-arm@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>,
kuhn.chenqun@huawei.com, philmd@redhat.com
Subject: Re: [PATCH v2 2/4] ads7846: put it into the 'display' category
Date: Thu, 12 Nov 2020 08:36:34 +0100 [thread overview]
Message-ID: <b8c51d7e-c16e-36a5-4500-e1e1cbf0d48f@redhat.com> (raw)
In-Reply-To: <20201111164710.644863-3-ganqixin@huawei.com>
On 11/11/2020 17.47, Gan Qixin wrote:
> The category of the ads7846 device is not set, put it into the 'display'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> hw/display/ads7846.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
> index 023165b2a3..b455cb5acd 100644
> --- a/hw/display/ads7846.c
> +++ b/hw/display/ads7846.c
> @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
>
> static void ads7846_class_init(ObjectClass *klass, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(klass);
> SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
>
> k->realize = ads7846_realize;
> k->transfer = ads7846_transfer;
> + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> }
>
> static const TypeInfo ads7846_info = {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-11-12 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 16:47 [PATCH v2 0/4] Categorize some uncategorized devices Gan Qixin
2020-11-11 16:47 ` [PATCH v2 1/4] ssd0323: put it into the 'display' category Gan Qixin
2020-11-12 7:34 ` Thomas Huth
2020-11-11 16:47 ` [PATCH v2 2/4] ads7846: " Gan Qixin
2020-11-12 7:36 ` Thomas Huth [this message]
2020-11-12 11:19 ` Peter Maydell
2020-11-12 11:53 ` ganqixin
2020-11-11 16:47 ` [PATCH v2 3/4] nand: put it into the 'storage' category Gan Qixin
2020-11-12 7:38 ` Thomas Huth
2020-11-11 16:47 ` [PATCH v2 4/4] max111x: put it into the 'misc' category Gan Qixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c51d7e-c16e-36a5-4500-e1e1cbf0d48f@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=ganqixin@huawei.com \
--cc=kraxel@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).