From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B1AC5517A for ; Thu, 12 Nov 2020 07:38:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77DF52222A for ; Thu, 12 Nov 2020 07:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dOg+dkqQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77DF52222A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd7Bq-0004du-34 for qemu-devel@archiver.kernel.org; Thu, 12 Nov 2020 02:38:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kd7AB-0003V6-F1 for qemu-devel@nongnu.org; Thu, 12 Nov 2020 02:36:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kd7A9-0003W2-P4 for qemu-devel@nongnu.org; Thu, 12 Nov 2020 02:36:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605166616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=frucbt3NJxjTlMYcCMvxFBrXRT6d2XPVWj3BlT44pJ4=; b=dOg+dkqQ+S/RGvWNjM6emmb3QZBDJi8bxEiiNfLMZP9ynbMef7VHnw7fGtU5LDGCUZ52/C HqDkZD/PDn5MgVNITgEmAOq8j5Je0tAdIt99lxi1I9eazQhAWzmx0WzoDECkUTXF+P7JQl OMF1qUsi3EfnQbZeGXhEpaAXXJSCpZQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-F8UJDFHfMsKWpnnnbDmdpA-1; Thu, 12 Nov 2020 02:36:53 -0500 X-MC-Unique: F8UJDFHfMsKWpnnnbDmdpA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CC5081CBE3; Thu, 12 Nov 2020 07:36:38 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-74.ams2.redhat.com [10.36.112.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6651375126; Thu, 12 Nov 2020 07:36:35 +0000 (UTC) Subject: Re: [PATCH v2 2/4] ads7846: put it into the 'display' category To: Gan Qixin , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: <20201111164710.644863-1-ganqixin@huawei.com> <20201111164710.644863-3-ganqixin@huawei.com> From: Thomas Huth Message-ID: Date: Thu, 12 Nov 2020 08:36:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201111164710.644863-3-ganqixin@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 00:51:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, laurent@vivier.eu, armbru@redhat.com, qemu-arm , Gerd Hoffmann , kuhn.chenqun@huawei.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/11/2020 17.47, Gan Qixin wrote: > The category of the ads7846 device is not set, put it into the 'display' > category. > > Signed-off-by: Gan Qixin > --- > hw/display/ads7846.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c > index 023165b2a3..b455cb5acd 100644 > --- a/hw/display/ads7846.c > +++ b/hw/display/ads7846.c > @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp) > > static void ads7846_class_init(ObjectClass *klass, void *data) > { > + DeviceClass *dc = DEVICE_CLASS(klass); > SSISlaveClass *k = SSI_SLAVE_CLASS(klass); > > k->realize = ads7846_realize; > k->transfer = ads7846_transfer; > + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > } > > static const TypeInfo ads7846_info = { > Reviewed-by: Thomas Huth