[PATCH v2 0/4] Categorize some uncategorized devices

[PATCH v2 0/4] Categorize some uncategorized devices

[Gan Qixin]

Hi all,

I found some uncategorized devices and categorize them in these patches.

Thanks,
Gan Qixin

v1->v2: Correct some spelling errors and limit commit message line length
to around 70.


Gan Qixin (4):
  ssd0323: put it into the 'display' category
  ads7846: put it into the 'display' category
  nand: put it into the 'storage' category
  max111x: put it into the 'misc' category

 hw/block/nand.c      | 1 +
 hw/display/ads7846.c | 2 ++
 hw/display/ssd0323.c | 1 +
 hw/misc/max111x.c    | 1 +
 4 files changed, 5 insertions(+)

-- 
2.23.0

[PATCH v2 1/4] ssd0323: put it into the 'display' category

[Gan Qixin]

The category of the ssd0323 device is not set, put it into the 'display'
category.

Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
 hw/display/ssd0323.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/display/ssd0323.c b/hw/display/ssd0323.c
index 17d4b32ae3..cbfd21dfd5 100644
--- a/hw/display/ssd0323.c
+++ b/hw/display/ssd0323.c
@@ -370,6 +370,7 @@ static void ssd0323_class_init(ObjectClass *klass, void *data)
     k->transfer = ssd0323_transfer;
     k->cs_polarity = SSI_CS_HIGH;
     dc->vmsd = &vmstate_ssd0323;
+    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
 }
 
 static const TypeInfo ssd0323_info = {
-- 
2.23.0

Re: [PATCH v2 1/4] ssd0323: put it into the 'display' category

[Thomas Huth]

On 11/11/2020 17.47, Gan Qixin wrote:
> The category of the ssd0323 device is not set, put it into the 'display'
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
>  hw/display/ssd0323.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/display/ssd0323.c b/hw/display/ssd0323.c
> index 17d4b32ae3..cbfd21dfd5 100644
> --- a/hw/display/ssd0323.c
> +++ b/hw/display/ssd0323.c
> @@ -370,6 +370,7 @@ static void ssd0323_class_init(ObjectClass *klass, void *data)
>      k->transfer = ssd0323_transfer;
>      k->cs_polarity = SSI_CS_HIGH;
>      dc->vmsd = &vmstate_ssd0323;
> +    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
>  }
>  
>  static const TypeInfo ssd0323_info = {
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH v2 2/4] ads7846: put it into the 'display' category

[Gan Qixin]

The category of the ads7846 device is not set, put it into the 'display'
category.

Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
 hw/display/ads7846.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
index 023165b2a3..b455cb5acd 100644
--- a/hw/display/ads7846.c
+++ b/hw/display/ads7846.c
@@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
 
 static void ads7846_class_init(ObjectClass *klass, void *data)
 {
+    DeviceClass *dc = DEVICE_CLASS(klass);
     SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
 
     k->realize = ads7846_realize;
     k->transfer = ads7846_transfer;
+    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
 }
 
 static const TypeInfo ads7846_info = {
-- 
2.23.0

Re: [PATCH v2 2/4] ads7846: put it into the 'display' category

[Thomas Huth]

On 11/11/2020 17.47, Gan Qixin wrote:
> The category of the ads7846 device is not set, put it into the 'display'
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
>  hw/display/ads7846.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
> index 023165b2a3..b455cb5acd 100644
> --- a/hw/display/ads7846.c
> +++ b/hw/display/ads7846.c
> @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
>  
>  static void ads7846_class_init(ObjectClass *klass, void *data)
>  {
> +    DeviceClass *dc = DEVICE_CLASS(klass);
>      SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
>  
>      k->realize = ads7846_realize;
>      k->transfer = ads7846_transfer;
> +    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
>  }
>  
>  static const TypeInfo ads7846_info = {
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH v2 2/4] ads7846: put it into the 'display' category

[Peter Maydell]

On Thu, 12 Nov 2020 at 07:25, Gan Qixin <ganqixin@huawei.com> wrote:
>
> The category of the ads7846 device is not set, put it into the 'display'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
>  hw/display/ads7846.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
> index 023165b2a3..b455cb5acd 100644
> --- a/hw/display/ads7846.c
> +++ b/hw/display/ads7846.c
> @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
>
>  static void ads7846_class_init(ObjectClass *klass, void *data)
>  {
> +    DeviceClass *dc = DEVICE_CLASS(klass);
>      SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
>
>      k->realize = ads7846_realize;
>      k->transfer = ads7846_transfer;
> +    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
>  }

This isn't a display, despite being in hw/display. It's a
touch-screen controller, so it ought to be in hw/input
and be DEVICE_CATEGORY_INPUT.

thanks
-- PMM

RE: [PATCH v2 2/4] ads7846: put it into the 'display' category

[ganqixin]

> -----Original Message-----
> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> Sent: Thursday, November 12, 2020 7:20 PM
> To: ganqixin <ganqixin@huawei.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; QEMU Trivial
> <qemu-trivial@nongnu.org>; Thomas Huth <thuth@redhat.com>;
> Zhanghailiang <zhang.zhanghailiang@huawei.com>; Michael S. Tsirkin
> <mst@redhat.com>; Laurent Vivier <laurent@vivier.eu>; Markus Armbruster
> <armbru@redhat.com>; Chenqun (kuhn) <kuhn.chenqun@huawei.com>;
> Philippe Mathieu-Daudé <philmd@redhat.com>
> Subject: Re: [PATCH v2 2/4] ads7846: put it into the 'display' category
> 
> On Thu, 12 Nov 2020 at 07:25, Gan Qixin <ganqixin@huawei.com> wrote:
> >
> > The category of the ads7846 device is not set, put it into the 'display'
> > category.
> >
> > Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> > ---
> >  hw/display/ads7846.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c index
> > 023165b2a3..b455cb5acd 100644
> > --- a/hw/display/ads7846.c
> > +++ b/hw/display/ads7846.c
> > @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error
> > **errp)
> >
> >  static void ads7846_class_init(ObjectClass *klass, void *data)  {
> > +    DeviceClass *dc = DEVICE_CLASS(klass);
> >      SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
> >
> >      k->realize = ads7846_realize;
> >      k->transfer = ads7846_transfer;
> > +    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> >  }
> 
> This isn't a display, despite being in hw/display. It's a touch-screen controller,
> so it ought to be in hw/input and be DEVICE_CATEGORY_INPUT.
> 
Thanks for your reply, I will recategorize ads7846.

Gan Qixin

[PATCH v2 3/4] nand: put it into the 'storage' category

[Gan Qixin]

The category of the nand device is not set, put it into the 'storage'
category.

Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
 hw/block/nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/block/nand.c b/hw/block/nand.c
index bcceb64ebb..1d7a48a2ec 100644
--- a/hw/block/nand.c
+++ b/hw/block/nand.c
@@ -449,6 +449,7 @@ static void nand_class_init(ObjectClass *klass, void *data)
     dc->reset = nand_reset;
     dc->vmsd = &vmstate_nand;
     device_class_set_props(dc, nand_properties);
+    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
 }
 
 static const TypeInfo nand_info = {
-- 
2.23.0

Re: [PATCH v2 3/4] nand: put it into the 'storage' category

[Thomas Huth]

On 11/11/2020 17.47, Gan Qixin wrote:
> The category of the nand device is not set, put it into the 'storage'
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
>  hw/block/nand.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/block/nand.c b/hw/block/nand.c
> index bcceb64ebb..1d7a48a2ec 100644
> --- a/hw/block/nand.c
> +++ b/hw/block/nand.c
> @@ -449,6 +449,7 @@ static void nand_class_init(ObjectClass *klass, void *data)
>      dc->reset = nand_reset;
>      dc->vmsd = &vmstate_nand;
>      device_class_set_props(dc, nand_properties);
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>  }
>  
>  static const TypeInfo nand_info = {
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH v2 4/4] max111x: put it into the 'misc' category

[Gan Qixin]

The category of the max111x device is not set, put it into the 'misc'
category.

Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
 hw/misc/max111x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/misc/max111x.c b/hw/misc/max111x.c
index 7e6723f343..eae0f9b598 100644
--- a/hw/misc/max111x.c
+++ b/hw/misc/max111x.c
@@ -185,6 +185,7 @@ static void max111x_class_init(ObjectClass *klass, void *data)
     k->transfer = max111x_transfer;
     dc->reset = max111x_reset;
     dc->vmsd = &vmstate_max111x;
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
 }
 
 static const TypeInfo max111x_info = {
-- 
2.23.0