From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: marcel@redhat.com, ehabkost@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names
Date: Thu, 13 Oct 2016 12:36:48 -0500 [thread overview]
Message-ID: <b8c57c51-53cf-d499-df13-c3ebb43ef4c4@redhat.com> (raw)
In-Reply-To: <1476377054-14572-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On 10/13/2016 11:44 AM, Markus Armbruster wrote:
> machine_set_property() replaces '_' by '-' in the property name.
> Except it fails to replace an initial '_'. Screwed up in commit
> b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property
> '._-foo-bar' not found".
>
> Error messages using a mangled name rather than the name the user
> actually wrote is user-hostile, but that's a different topic.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> vl.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-10-13 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 16:44 [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names Markus Armbruster
2016-10-13 17:36 ` Eric Blake [this message]
2016-10-13 17:41 ` Eduardo Habkost
2016-10-17 11:00 ` Markus Armbruster
2016-10-17 13:44 ` Eduardo Habkost
2016-10-17 17:10 ` Markus Armbruster
2016-10-17 17:20 ` Eduardo Habkost
2016-10-13 17:47 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c57c51-53cf-d499-df13-c3ebb43ef4c4@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).