From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bujw3-0006bG-GV for qemu-devel@nongnu.org; Thu, 13 Oct 2016 13:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bujw2-0004y1-Ig for qemu-devel@nongnu.org; Thu, 13 Oct 2016 13:36:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bujw2-0004xr-DE for qemu-devel@nongnu.org; Thu, 13 Oct 2016 13:36:50 -0400 References: <1476377054-14572-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: Date: Thu, 13 Oct 2016 12:36:48 -0500 MIME-Version: 1.0 In-Reply-To: <1476377054-14572-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="co153oQLF9XaCGeS9W6qxl0NGbix1DGWx" Subject: Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: marcel@redhat.com, ehabkost@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --co153oQLF9XaCGeS9W6qxl0NGbix1DGWx From: Eric Blake To: Markus Armbruster , qemu-devel@nongnu.org Cc: marcel@redhat.com, ehabkost@redhat.com, afaerber@suse.de Message-ID: Subject: Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names References: <1476377054-14572-1-git-send-email-armbru@redhat.com> In-Reply-To: <1476377054-14572-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/13/2016 11:44 AM, Markus Armbruster wrote: > machine_set_property() replaces '_' by '-' in the property name. > Except it fails to replace an initial '_'. Screwed up in commit > b0ddb8b. Reproducer: "-M pc,__foo_bar=3Dtrue" produces "Property > '._-foo-bar' not found". >=20 > Error messages using a mangled name rather than the name the user > actually wrote is user-hostile, but that's a different topic. >=20 > Signed-off-by: Markus Armbruster > --- > vl.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --co153oQLF9XaCGeS9W6qxl0NGbix1DGWx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX/8YwAAoJEKeha0olJ0Nqu8sH/RyjTu5mwD1uHT0M15k4zfgX 8zbtyIWcK+XSR/kfkp++uxIDii8sjkeeGDuY3JMlgheLUoY8NMfzcyTXhJ3PGzY/ zshiMkgJhiADWV4qcd5v5AELvePA1eRUrrSuujQGcKsRfj2GlEQQvQOTBJh3ueXs lcxx1qrwdKAIWgMvY1aM1hrIJrpqwIZXXb6WJK04OjARsqf3Df+Jxw0wCfFgH+lH MFvLbNdhJbcem/omtooQh9aMSVSY3FiYGfpg6pNJ7R4NsCvrmCDd5K8pLKBUColb VyNWK9/Xbn00ctP8bS5fHm/8bdStqY1UfkvOClo4ZoLnGEvSg4gH9tyO1ClTxb0= =zyI7 -----END PGP SIGNATURE----- --co153oQLF9XaCGeS9W6qxl0NGbix1DGWx--