From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD366C04AB4 for ; Tue, 14 May 2019 10:44:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B50FD20881 for ; Tue, 14 May 2019 10:44:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B50FD20881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:45170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUvU-0007ly-09 for qemu-devel@archiver.kernel.org; Tue, 14 May 2019 06:44:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUr9-00049o-6U for qemu-devel@nongnu.org; Tue, 14 May 2019 06:40:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQUif-0008RF-RV for qemu-devel@nongnu.org; Tue, 14 May 2019 06:31:40 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45299) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQUie-0008OF-2h for qemu-devel@nongnu.org; Tue, 14 May 2019 06:31:37 -0400 Received: by mail-wr1-f67.google.com with SMTP id b18so8609202wrq.12 for ; Tue, 14 May 2019 03:31:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VmJfXoC2WzST8DEgwuGF4IR2cehYCXYnXTuYbo9V1ek=; b=lSPcZP3lYi7WGvLV+9Y2CBVu9OE0eftuBJ2LGrqazQhyZt2wLOaysxwriFOtRaJ4kY 3/rv3qAK/WLYpKieXHrwX6wDvOq+t4VyV7Vh/RwhH2Uc6FeCkeKhe7WOrniKZ9BwtoNH BBICGMvA0VhDquJD3JAnUfjAzv5GIeNGAdU8vVCHMP/sF4KgsybncobLYnXZgziWSONP DDFqTgXsUB0V4sgjjvIXW64z5fJEbGarLKsKs1xIwlcfn9wSciFh6f1PAZlmBGuUfphs Ndqw4v82mOPa66qTLtUhq+LaW4Vn8oe+fUCR9O/5c/Vwy81Vz0xNJh56kJuSV/3Q8Bo1 N9ag== X-Gm-Message-State: APjAAAWMGGxC75JZlEVvvF2TzRm8viHH+PV0WzgDRfrqGg71hLfglUcS Czx4uGRSKOBHkFJgOpar8Nrrqw== X-Google-Smtp-Source: APXvYqyvw0y5IlR+fOse6T5W+dmIwfwmj1mTJIkcz+u97f41RQLvxIXlGwmoaGpyH/qFuxnSdTUNdQ== X-Received: by 2002:a05:6000:43:: with SMTP id k3mr21264111wrx.234.1557829894567; Tue, 14 May 2019 03:31:34 -0700 (PDT) Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id o4sm2766773wmc.38.2019.05.14.03.31.33 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 03:31:33 -0700 (PDT) To: Thomas Huth , Paolo Bonzini , qemu-devel@nongnu.org References: <20190514100019.13263-1-thuth@redhat.com> <20190514100019.13263-2-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Tue, 14 May 2019 12:31:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514100019.13263-2-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.67 Subject: Re: [Qemu-devel] [PATCH 1/4] hw/core: Add a config switch for the "register" device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/14/19 12:00 PM, Thomas Huth wrote: > The "register" device is only used by certain machines. Let's add > a proper config switch for it so that it only gets compiled when we > really need it. > > Signed-off-by: Thomas Huth > --- > hw/core/Kconfig | 3 +++ > hw/core/Makefile.objs | 2 +- > hw/dma/Kconfig | 1 + > hw/timer/Kconfig | 1 + > 4 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/core/Kconfig b/hw/core/Kconfig > index c2a1ae8122..d11920fcb3 100644 > --- a/hw/core/Kconfig > +++ b/hw/core/Kconfig > @@ -9,3 +9,6 @@ config FITLOADER > > config PLATFORM_BUS > bool > + > +config REGISTER > + bool > diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs > index a799c83815..d493a051ee 100644 > --- a/hw/core/Makefile.objs > +++ b/hw/core/Makefile.objs > @@ -16,7 +16,7 @@ common-obj-$(CONFIG_SOFTMMU) += machine.o > common-obj-$(CONFIG_SOFTMMU) += loader.o > common-obj-$(CONFIG_FITLOADER) += loader-fit.o > common-obj-$(CONFIG_SOFTMMU) += qdev-properties-system.o > -common-obj-$(CONFIG_SOFTMMU) += register.o > +common-obj-$(CONFIG_REGISTER) += register.o > common-obj-$(CONFIG_SOFTMMU) += or-irq.o > common-obj-$(CONFIG_SOFTMMU) += split-irq.o > common-obj-$(CONFIG_PLATFORM_BUS) += platform-bus.o > diff --git a/hw/dma/Kconfig b/hw/dma/Kconfig > index 751dec5426..5c61b67bc0 100644 > --- a/hw/dma/Kconfig > +++ b/hw/dma/Kconfig > @@ -16,6 +16,7 @@ config I8257 > > config ZYNQ_DEVCFG > bool > + select REGISTER > > config STP2000 > bool > diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig > index 51921eb63f..f575481210 100644 > --- a/hw/timer/Kconfig > +++ b/hw/timer/Kconfig > @@ -36,6 +36,7 @@ config TWL92230 > > config XLNX_ZYNQMP > bool > + select REGISTER > > config ALTERA_TIMER > bool > Annoying, this clashes with "hw/microblaze: Kconfig cleanup" which is already queued by Paolo: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04669.html