From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fouis-0004fo-0Q for qemu-devel@nongnu.org; Sun, 12 Aug 2018 14:04:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fouiK-000323-Sd for qemu-devel@nongnu.org; Sun, 12 Aug 2018 14:04:13 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:38546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fouiI-0002uI-VW for qemu-devel@nongnu.org; Sun, 12 Aug 2018 14:03:40 -0400 Received: by mail-wr1-x42e.google.com with SMTP id v14-v6so12369260wro.5 for ; Sun, 12 Aug 2018 11:03:38 -0700 (PDT) References: <0c215752-5cd2-3b7c-bc3c-f435f1dbbfed@bluestop.org> <8bf07395-4872-ce74-c201-9fca232edd01@gmail.com> <80532e46-ffbf-9c87-5296-741bbb6f83ac@redhat.com> <1feb3cc1-86ee-f708-6dc7-b9e20a7588ac@redhat.com> <5434c03d-7d03-8255-ea0f-d85ec96ac844@gmail.com> <20180812083918.GA3004@lap1> From: Marcel Apfelbaum Message-ID: Date: Sun, 12 Aug 2018 15:10:12 +0300 MIME-Version: 1.0 In-Reply-To: <20180812083918.GA3004@lap1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuval Shaia Cc: Thomas Huth , Rebecca Cran , qemu-devel@nongnu.org, Peter Maydell , Kamil Rytarowski , Brad Smith On 08/12/2018 11:39 AM, Yuval Shaia wrote: > On Sat, Aug 11, 2018 at 07:47:49PM +0300, Marcel Apfelbaum wrote: >> Hi, >> >> On 08/06/2018 11:51 AM, Thomas Huth wrote: >>> On 07/28/2018 05:50 AM, Rebecca Cran wrote: >>>> On 7/25/18 5:14 AM, Thomas Huth wrote: >>>> >>>>> Note that the error has been reported to happen on FreeBSD - so I doubt >>>>> that this header should be here. >>>>> >>>>> Anyway, our include/standard-headers/linux/types.h is also empty ... so >>>>> could you try whether it compiles if you simply remove this #include >>>>> line, Rebecca? >>>> Sorry for the delay, I'm just getting back to this. Removing the include >>>> causes it to fail later on, with: >>>> >>>> /home/bcran/workspace/qemu/hw/rdma/vmw/pvrdma_cmd.c:60:17: warning: >>>> implicit declaration of function 'mremap' is invalid in C99 >>>> [-Wimplicit-function-declaration] >>>>     host_virt = mremap(curr_page, 0, length, MREMAP_MAYMOVE); >>> OK, thanks for checking. According to >>> >>> https://www.freebsd.org/cgi/man.cgi?query=mremap&manpath=NetBSD+5.0 >>> >>> that syscall should also be available on FreeBSD. So could you please do >>> one more test and see whether it works when you add the following line >>> somewhere at the beginning of the file: >>> >>> #include >> It took some time, but I finally have a FreeBSD VM with RDMA enabled. >> >> My findings: >> - The RDMA libraries are there, so the flag  "RDMA"=yes is set correctly. >> - include of is not needed, I will remove it. >> - In FreeBSD mremap is not implemented in all configurations, it depends >>   on some SANITIZER_LINUX flag (Linux emulation?), I think; >>   so pvrdma cannot be compiled.  I think we should have a different QEMU >> configuration >>   flag --enable-pvrdma that will specifically check it is not a "bsd" >> platform. > A good idea. > > So, do i get it right that you will "revert back" the things we did > to--enable-rdma and do all our stuff in new --enable-pvrdma section? Yes, but I plan to do it as a patch "on top" rather than reverting the actual commit. Thanks, Marcel >>   I'll send a patch for that too. >> >> Thanks, >> Marcel >> >> >>> Thanks, >>> Thomas