From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Michael Roth <michael.roth@amd.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Tomáš Golembiovský" <tgolembi@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()
Date: Sun, 8 Nov 2020 18:09:03 +0100 [thread overview]
Message-ID: <b8ef4b32-ef30-a1ac-5ea1-525402821eae@redhat.com> (raw)
In-Reply-To: <20201108161112.187945-1-michael.roth@amd.com>
On 11/8/20 5:11 PM, Michael Roth wrote:
> We opendir("/sys/block") at the beginning of the function, but we never
> close it prior to returning.
>
> Fixes: Coverity CID 1436130
> Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Tomáš Golembiovský <tgolembi@redhat.com>
> Signed-off-by: Michael Roth <michael.roth@amd.com>
> ---
> qga/commands-posix.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2020-11-08 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 16:11 [PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks() Michael Roth
2020-11-08 17:09 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8ef4b32-ef30-a1ac-5ea1-525402821eae@redhat.com \
--to=philmd@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tgolembi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).