From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6gMr-0007bb-GY for qemu-devel@nongnu.org; Thu, 12 Apr 2018 13:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6gMm-000430-GZ for qemu-devel@nongnu.org; Thu, 12 Apr 2018 13:50:41 -0400 References: <20180412093521.2469-1-david@redhat.com> From: Thomas Huth Message-ID: Date: Thu, 12 Apr 2018 19:50:21 +0200 MIME-Version: 1.0 In-Reply-To: <20180412093521.2469-1-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] s390x/kvm: cleanup calls to cpu_synchronize_state() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-s390x@nongnu.org Cc: qemu-devel@nongnu.org, Richard Henderson , Alexander Graf , Cornelia Huck , Christian Borntraeger On 12.04.2018 11:35, David Hildenbrand wrote: > We have a call to cpu_synchronize_state() on every kvm_arch_handle_exit(). > > Let's remove the ones that are no longer needed. > > Remaining places (for s390x) are in > - target/s390x/sigp.c, on the target CPU > - target/s390x/cpu.c:s390_cpu_get_crash_info() > > While at it, use kvm_cpu_synchronize_state() instead of > cpu_synchronize_state() in KVM code. (suggested by Thomas Huth) > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-pci-inst.c | 8 -------- > target/s390x/kvm.c | 20 +------------------- > 2 files changed, 1 insertion(+), 27 deletions(-) Wow, that was really a mess, looking at which different "levels" the cpu_synchronize_state was done before. Good that you cleaned it up now. Reviewed-by: Thomas Huth