From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>,
Deepa Srinivasan <deepa.srinivasan@oracle.com>
Cc: stefanha@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, mark.kanda@oracle.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block
Date: Thu, 23 Nov 2017 18:31:00 +0100 [thread overview]
Message-ID: <b9092b47-2cb0-283f-afb5-a9a447f11012@redhat.com> (raw)
In-Reply-To: <20171123172927.GD4375@localhost.localdomain>
On 23/11/2017 18:29, Kevin Wolf wrote:
>> Note that a similar issue exists in
>> blk_ioctl()/blk_ioctl_entry()/blk_prw() where blk_prw() always creates
>> the QEMUIOVector even if blk_ioctl()/blk_ioctl_entry() does not need a
>> QEMUIOVector. This will need to be fixed separately to keep it
>> consistent with the AIO path.
>
> I don't think there is an actual problem in the blk_ioctl() path because
> the iov on the stack stays valid as long as the coroutine runs. AIO is
> different because it returns before the coroutine has terminated.
I agree, it's just code that is slightly ugly.
Paolo
next prev parent reply other threads:[~2017-11-23 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 15:33 [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block Deepa Srinivasan
2017-11-22 16:34 ` Paolo Bonzini
2017-11-22 18:06 ` Kevin Wolf
2017-11-22 19:24 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2017-11-23 2:55 ` Deepa Srinivasan
2017-11-23 9:18 ` Paolo Bonzini
2017-11-23 16:55 ` [Qemu-devel] " Deepa Srinivasan
2017-11-23 17:05 ` Deepa Srinivasan
2017-11-23 17:17 ` Paolo Bonzini
2017-11-23 17:29 ` Kevin Wolf
2017-11-23 17:31 ` Paolo Bonzini [this message]
2017-11-23 17:34 ` Kevin Wolf
2017-11-27 18:45 ` Deepa Srinivasan
2017-12-01 17:27 ` Deepa Srinivasan
2017-11-22 17:06 ` Stefan Hajnoczi
2017-11-22 18:04 ` Kevin Wolf
2017-11-23 10:23 ` Stefan Hajnoczi
2017-11-23 10:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9092b47-2cb0-283f-afb5-a9a447f11012@redhat.com \
--to=pbonzini@redhat.com \
--cc=deepa.srinivasan@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kwolf@redhat.com \
--cc=mark.kanda@oracle.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).