From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHvLH-0000O1-MS for qemu-devel@nongnu.org; Thu, 23 Nov 2017 12:31:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHvLH-0006oD-20 for qemu-devel@nongnu.org; Thu, 23 Nov 2017 12:31:15 -0500 References: <1511456107-7081-1-git-send-email-deepa.srinivasan@oracle.com> <3DFDA265-8685-4601-B981-1BB0007C44B4@oracle.com> <20171123172927.GD4375@localhost.localdomain> From: Paolo Bonzini Message-ID: Date: Thu, 23 Nov 2017 18:31:00 +0100 MIME-Version: 1.0 In-Reply-To: <20171123172927.GD4375@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Deepa Srinivasan Cc: stefanha@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, mark.kanda@oracle.com, Konrad Rzeszutek Wilk On 23/11/2017 18:29, Kevin Wolf wrote: >> Note that a similar issue exists in >> blk_ioctl()/blk_ioctl_entry()/blk_prw() where blk_prw() always creates >> the QEMUIOVector even if blk_ioctl()/blk_ioctl_entry() does not need a >> QEMUIOVector. This will need to be fixed separately to keep it >> consistent with the AIO path. > > I don't think there is an actual problem in the blk_ioctl() path because > the iov on the stack stays valid as long as the coroutine runs. AIO is > different because it returns before the coroutine has terminated. I agree, it's just code that is slightly ugly. Paolo