From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26034C433E6 for ; Tue, 1 Sep 2020 18:05:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D113B2071B for ; Tue, 1 Sep 2020 18:05:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bmKZM+xD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D113B2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDAep-0004U3-R9 for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 14:05:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDAeC-00044a-3A for qemu-devel@nongnu.org; Tue, 01 Sep 2020 14:04:44 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:38649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDAeA-0004JL-KD for qemu-devel@nongnu.org; Tue, 01 Sep 2020 14:04:43 -0400 Received: by mail-pf1-x443.google.com with SMTP id d22so1258574pfn.5 for ; Tue, 01 Sep 2020 11:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R4NgC7Vm6JH1Qb5iAi0jM+XJUlte8bnHVDbh2tm58zU=; b=bmKZM+xDuYpvdGv7wW7VTh5ixzBbqR2kZcgiNI2vAA6DgmpSQmWcYx6fkoZKkilSew S6dCyNrIb3BojtoXBObEER+S5r0EbSY4Qd3cXUgG6BcwQhwtXVAVXAJ6n8ic3PhVLRS6 w8DtWhTXhpGwpsUS874U47rpmvTy6VCbMvFl1KzcD/ifd7S52l+aiEb4HncrhLrmAjuR EXyoL+O2+WaNrgyk6qS9wvBvCmBO+oG5DEWjAsBu3orQd+qI+NYmIQvz2QVvKceKbvf2 ZVqLlyuVU2ANWOCUk8J9uzFDYmO3OgiBR7xJbpRAWeN/08UOIQBWWcvS4ivJrRlb5kyY GfCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R4NgC7Vm6JH1Qb5iAi0jM+XJUlte8bnHVDbh2tm58zU=; b=OFmIGm73Tk2rekxV1qPlsLWff9D4BMFEr9wGKCFB1RxC2TeKdoHc4acd8E1GROwV8I r1iTS/GpOU75O7uVmU7Eyz99yV1TaSvJWbMiUDLwYKGQqc+dEXAs+Nf2DWCjsV/Kz6b5 sStwKPMektulTcXSJaHYzcnbezy4x//GVcyYlFc7vCiKE3rIJBPVIF5dlW49qetaiREY KJGbbTWXWM54TDXJV3//MzJd//rZ47g0QGVBKH9Lf2hixYyb4ldADztuuTgtfJlrLeDD dikroNMx2QMyO/7YnGdqKnGsgLW/0V7p83nXSkIcQ/QIJkCz+oTB5FNYUvRlCQJ1GM8s oXUA== X-Gm-Message-State: AOAM531fG+ZxF9L1wEW40P3C9DrnzTTvHK6AhYOdx7FJijaBsD9mUVr2 Q/gYLwveJjOAFgQp4dJYSWjBiA== X-Google-Smtp-Source: ABdhPJx2BVnuEIUcawKXOn9vHqiMSgYiRSWBIB+Uv5/IMNXWkAvHQrf5oXseWaubSVXbiWtX5vYoKQ== X-Received: by 2002:a63:2a96:: with SMTP id q144mr2576373pgq.447.1598983480788; Tue, 01 Sep 2020 11:04:40 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id v21sm2122715pjn.4.2020.09.01.11.04.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 11:04:39 -0700 (PDT) Subject: Re: [PATCH 03/13] oslib-posix: default exec_dir to bindir To: Paolo Bonzini , qemu-devel@nongnu.org References: <20200901062020.26660-1-pbonzini@redhat.com> <20200901062020.26660-4-pbonzini@redhat.com> From: Richard Henderson Message-ID: Date: Tue, 1 Sep 2020 11:04:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200901062020.26660-4-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.13, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/31/20 11:20 PM, Paolo Bonzini wrote: > + exec_dir = g_strdup(CONFIG_BINDIR); Why the strdup? The string constant should be fine, IIUC. r~