From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <dovgaluk@ispras.ru>,
'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, quintela@redhat.com,
jasowang@redhat.com, mst@redhat.com, agraf@suse.de,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state
Date: Fri, 16 Sep 2016 11:29:16 +0200 [thread overview]
Message-ID: <b94d3eaa-f21b-9cfa-0cac-729ac7bfdd88@redhat.com> (raw)
In-Reply-To: <001b01d20fef$ca246970$5e6d3c50$@ru>
On 16/09/2016 09:56, Pavel Dovgalyuk wrote:
>>> > > +{
>>> > > + if (replay_mode == REPLAY_MODE_RECORD) {
>>> > > + QDict *opts = qdict_new();
>>> > > + qdict_put(opts, "name", qstring_from_str("replay_init"));
>>> > > + hmp_savevm(cur_mon, opts);
>>> > > + QDECREF(opts);
>>> > > + } else if (replay_mode == REPLAY_MODE_PLAY) {
>>> > > + load_vmstate("replay_init");
>> >
>> > See my other message about a suggestion to remove the hardcoded snapshot
>> > name.
>> >
>> > Also, I think the return value of load_vmstate and hmp_savevm should be
>> > checked.
>
> Load may be unsuccessful when the system is started with temporary overlay file.
> This is ok.
This seems to be in favor of using a rrsnapshot option instead. Using
rrsnapshot for temporary overlay would make little sense.
Paolo
next prev parent reply other threads:[~2016-09-16 9:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 9:00 [Qemu-devel] [PATCH v2 00/10] replay additions Pavel Dovgalyuk
2016-09-15 9:00 ` [Qemu-devel] [PATCH v2 01/10] record/replay: add network support Pavel Dovgalyuk
2016-09-15 9:00 ` [Qemu-devel] [PATCH v2 02/10] block: set snapshot option for block devices in blkreplay module Pavel Dovgalyuk
2016-09-15 9:25 ` Paolo Bonzini
2016-09-15 9:36 ` Paolo Bonzini
2016-09-16 7:55 ` Pavel Dovgalyuk
2016-09-16 9:28 ` Paolo Bonzini
2016-09-16 9:36 ` Pavel Dovgalyuk
2016-09-16 9:49 ` Paolo Bonzini
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 03/10] block: don't make snapshots for filters Pavel Dovgalyuk
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state Pavel Dovgalyuk
2016-09-15 9:25 ` Paolo Bonzini
2016-09-16 7:56 ` Pavel Dovgalyuk
2016-09-16 9:29 ` Paolo Bonzini [this message]
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 05/10] replay: move internal data to the structure Pavel Dovgalyuk
2016-09-15 9:34 ` Paolo Bonzini
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 06/10] replay: vmstate for replay module Pavel Dovgalyuk
2016-09-15 9:37 ` Paolo Bonzini
2016-09-16 7:36 ` Pavel Dovgalyuk
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 07/10] replay: allow replay stopping and restarting Pavel Dovgalyuk
2016-09-15 9:38 ` Paolo Bonzini
2016-09-16 6:35 ` Pavel Dovgalyuk
2016-09-16 8:55 ` Paolo Bonzini
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 08/10] kvmvapic: fix state change handler Pavel Dovgalyuk
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 09/10] pcspk: adding vmstate for save/restore Pavel Dovgalyuk
2016-09-15 9:01 ` [Qemu-devel] [PATCH v2 10/10] integratorcp: " Pavel Dovgalyuk
2016-09-15 9:12 ` [Qemu-devel] [PATCH v2 00/10] replay additions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b94d3eaa-f21b-9cfa-0cac-729ac7bfdd88@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).